Skip to content

Add models CLI config schema#5885

Merged
hyperupcall merged 3 commits into
SchemaStore:masterfrom
Nick2bad4u:schema/modelsdev-config
Jul 7, 2026
Merged

Add models CLI config schema#5885
hyperupcall merged 3 commits into
SchemaStore:masterfrom
Nick2bad4u:schema/modelsdev-config

Conversation

@Nick2bad4u

Copy link
Copy Markdown
Contributor

Summary

  • add a JSON Schema for the models CLI TOML configuration
  • register the default models config path in the SchemaStore catalog
  • add positive and negative TOML fixtures

Validation

  • node ./cli.js check --schema-name=modelsdev.json

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@hyperupcall

Copy link
Copy Markdown
Member

Thanks! Unfortunately the fileMatch field is too generic and likely to have false positives. Could a more specific pattern work, or is this schema some sort of common standard used across many tools and companies?

@Nick2bad4u

Copy link
Copy Markdown
Contributor Author

Removed the generic fileMatch from the catalog entry so this schema is available by URL/manual association without risking false positives. The PR is clean now, and validation is passing.

@hyperupcall hyperupcall merged commit 255e27a into SchemaStore:master Jul 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants