tsconfig: Add minLength validation to path in project reference#5873
Merged
Conversation
An empty string works in ts6, but will not in ts7. ref microsoft/typescript-go#4484
HolgerJeromin
requested review from
hyperupcall and
madskristensen
as code owners
HolgerJeromin
changed the title
Contributor
|
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
Member
|
Thanks, should this be added to JSConfig as well? |
Contributor
Author
Good point. |
Member
|
Great thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty string works in ts6, but will not in ts7 aka tsgo.
(and is quite a bad idea even in older versions)
ref microsoft/typescript-go#4484