Fix VectorTileSource in SvelteKit builds#349
Merged
awesomephant merged 22 commits intomainfrom Apr 7, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was caused by a race condition between
VectorTileSourceandVectorLayer. For some unknown reason,VectorLayeris mounted first in production builds independent of source order (not in dev), which causes it to break because its source doesn't exist yet.We fix that by nesting
VectorLayerinsideVectorSource, which makes the mounting order deterministic (other projects take the same approach):This PR:
waitForStyleLoaded()method toMapContextto queue source/layers in the correct orderVectorTileSourceandVectorLayerCloses #348