MTA: sliced-pipeline coverage tests#190
Open
JoelYYoung wants to merge 8 commits into
Open
Conversation
New ctest suites (whole-program, single-slice, observe, main-ila, saber full-svfg) plus no_data_race and single_threaded cases covering the pipeline's guard paths. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Use concise, descriptive names matching the suite's style. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add mta_race_count_tests: for each known program, assert the exact sliced (MSli) and whole-program (FSAM) race count, so a silent mis-detection or a sliced/whole divergence fails the suite. The other MTA suites only check that mta runs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The in-tool MTA annotation validation was removed in the refactor, so these grep-based ctest assertions were inconsistent with the rest of the (exit-code) MTA suite. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Collaborator
|
Better to rename the option to be mta-slicing rather than -enable-slicing. Pls also change other options to make them explicitly related to mta |
Follow the SVF option rename: -enable-slicing -> -mta-enable-slicing, -mt-flow-sensitive -> -mta-flow-sensitive, -slicing-single -> -mta-slicing-single. Drop the main-ila-sliced and observe test blocks (those options were removed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test cases exercising the multi-stage on-demand slicing (MSli) MTA pipeline; companion to SVF-tools/SVF#1852.
-enable-slicing=false), single unified slice (-slicing-single), observe mode (-observe), main-ila-sliced, andsaber -saber-full-svfg.no_data_raceandsingle_threaded, covering the pipeline's "no race pairs" and "no thread functions" guard paths.🤖 Generated with Claude Code