Skip to content

Fix macOS CI compile failure by explicitly including SVFGBuilder header#80

Merged
yuleisui merged 2 commits into
masterfrom
copilot/fix-macos-build-job
Jul 10, 2026
Merged

Fix macOS CI compile failure by explicitly including SVFGBuilder header#80
yuleisui merged 2 commits into
masterfrom
copilot/fix-macos-build-job

Conversation

Copilot AI commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

The build (macos-latest) GitHub Actions job failed in build-svf-from-scratch with unknown type name 'SVFGBuilder'. The source used SVFGBuilder without including its declaring header, which was masked by transitive includes on other environments.

  • Build break root cause

    • src/svf-example.cpp instantiated SVFGBuilder but only included Graphs/SVFG.h, not the builder declaration.
  • Targeted code change

    • Added explicit include for SVFGBuilder:
      • #include "MSSA/SVFGBuilder.h"
  • Why this matters

    • Removes reliance on transitive include behavior and makes compilation deterministic across toolchains/platforms (including macOS).
#include "Graphs/SVFG.h"
#include "MSSA/SVFGBuilder.h"

Copilot AI changed the title [WIP] Fix failing GitHub Actions job build (macos-latest) Fix macOS CI compile failure by explicitly including SVFGBuilder header Jul 10, 2026
Copilot AI requested a review from yuleisui July 10, 2026 02:16
@yuleisui
yuleisui marked this pull request as ready for review July 10, 2026 02:20
Copilot AI review requested due to automatic review settings July 10, 2026 02:20
@yuleisui
yuleisui merged commit 3cd13ef into master Jul 10, 2026
4 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a macOS CI compilation failure by making SVFGBuilder’s declaration available via an explicit header include, avoiding reliance on transitive includes that differ across toolchains/platforms.

Changes:

  • Added #include "MSSA/SVFGBuilder.h" to src/svf-example.cpp to ensure SVFGBuilder is declared where it’s used.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants