Skip to content
This repository was archived by the owner on Mar 29, 2022. It is now read-only.

Complete refactor - #8

Open
ethho wants to merge 80 commits into
masterfrom
develop-eho
Open

Complete refactor#8
ethho wants to merge 80 commits into
masterfrom
develop-eho

Conversation

@ethho

@ethho ethho commented Mar 23, 2021

Copy link
Copy Markdown
Contributor

Refactored for "next-gen" Tapis Actors/Reactors SDK (python-reactors), which is abstracted away to a dedicated repo.

  • Only builds one image: sd2e/reactors:python3
  • Depends on python-reactors packaging for dependency installation/management

Ethan Ho added 30 commits March 19, 2021 14:39
docker run --rm -it sd2e/reactors:python3 pip3 freeze > default-actor-context/requirements.txt
Same Python version as old sd2e/reactors:python3
Will be included with new SDK
@ethho

ethho commented Apr 16, 2021

Copy link
Copy Markdown
Contributor Author

To Do

Test CI push of sd2etest/reactors:python3:

  • @mwvaughn or @johnfonner:sd2etest credentials >> GitHub Repository secrets
    • TAPIS_PASSWORD
    • DOCKER_PASSWORD
  • Setting these secrets will not push to sd2e/reactors:python3 until DOCKER_ORG=sd2e in docker-publish.yml.
    • @eho-tacc will put this one line change in a separate PR once we're ready to push to DockerHub prod

@ethho

ethho commented Apr 29, 2021

Copy link
Copy Markdown
Contributor Author

Using tapis_optional removes requirement to generate Tapis token via CLI.

@ethho

ethho commented May 5, 2021

Copy link
Copy Markdown
Contributor Author

8102101 ensures that path to message schema stays the same as old Dockerfile:

ONBUILD ADD message.json* /message.jsonschema

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant