gccrs: Refactor query_type to only fully-const resolve const fns - #4881
Merged
Conversation
When we are in a const context what can happen is we start to query all non const types during method resolution for example which means its going to query fn signitures and fully resolve their blocks for non const candidates. gcc/rust/ChangeLog: * typecheck/rust-type-util.cc (query_type): dont query non const candidates Signed-off-by: Philip Herron <herron.philip@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we are in a const context what can happen is we start to query all non const types during method resolution for example which means its going to query fn signitures and fully resolve their blocks for non const candidates.
gcc/rust/ChangeLog: