gccrs: improve handling of defered operator overload handling - #4850
Merged
Conversation
When we are compiling libcore each operation +-/* etc all resolve to libcore implementations of these that define the semantics but what can happen is because of infer vars its ambigious what implementation this should specialize to untill more type hints are applied so we return an infer variable result so type checking can continue and we try to resolve at the end. gcc/rust/ChangeLog: * typecheck/rust-hir-dot-operator.cc (MethodResolver::Select): optional result type * typecheck/rust-hir-dot-operator.h: likewise * typecheck/rust-hir-type-check-expr.cc (TypeCheckExpr::ResolveOpOverload): defer flag (TypeCheckExpr::visit): pass throw the borrow * typecheck/rust-hir-type-check-expr.h: likewise * typecheck/rust-hir-type-check.h (struct DeferredOpOverload): new * typecheck/rust-type-util.cc (unify_site): like parameter ordering (unify_site_and): likewise * typecheck/rust-typecheck-context.cc (TypeCheckContext::compute_ambigious_op_overload): new (TypeCheckContext::compute_inference_variables): likewise (TypeCheckContext::compute_infer_var): likewise * typecheck/rust-unify.cc (UnifyRules::Resolve): fix arguments (UnifyRules::resolve_subtype):likewise * typecheck/rust-unify.h: likewise gcc/testsuite/ChangeLog: * rust/execute/torture/deferred-add-partial-ord.rs: New test. Signed-off-by: Philip Herron <herron.philip@googlemail.com>
philberty
force-pushed
the
phil/dev-defer
branch
from
September 6, 2026 18:25
47a6a0e to
34a64f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we are compiling libcore each operation +-/* etc all resolve to libcore implementations of these that define the semantics but what can happen is because of infer vars its ambigious what implementation this should specialize to untill more type hints are applied so we return an infer variable result so type checking can continue and we try to resolve at the end.
gcc/rust/ChangeLog:
gcc/testsuite/ChangeLog: