Skip to content

Combined unused lints - #4797

Open
lucasly-ba wants to merge 7 commits into
Rust-GCC:masterfrom
lucasly-ba:combined-unused-lints
Open

Combined unused lints#4797
lucasly-ba wants to merge 7 commits into
Rust-GCC:masterfrom
lucasly-ba:combined-unused-lints

Conversation

@lucasly-ba

Copy link
Copy Markdown
Contributor

As requested by @philberty on #4639, a single PR combining #4622, #4623, #4624, #4626, #4629, #4639 and #4642

@philberty

Copy link
Copy Markdown
Member

the commit format needs fixed up

gcc/rust/ChangeLog:

	* checks/lints/unused/rust-unused-checker.cc (BoolLiteral): New.
	(ConstantTruth): New.
	(UnusedChecker::visit): New.
	* checks/lints/unused/rust-unused-checker.h (UnusedChecker::visit):
	New.

gcc/testsuite/ChangeLog:

	* rust/compile/while-true_0.rs: New test.

Signed-off-by: Lucas Ly Ba <lucas.ly-ba@outlook.com>
gcc/rust/ChangeLog:

	* checks/lints/unused/rust-unused-checker.cc (UnusedChecker::visit):
	New.
	* checks/lints/unused/rust-unused-checker.h (UnusedChecker::visit):
	New.
	* rust-lang.cc (grs_langhook_init_options_struct): Enable warn_unused_value.

gcc/testsuite/ChangeLog:

	* rust/compile/path-statements_0.rs: New test.

Signed-off-by: Lucas Ly Ba <lucas.ly-ba@outlook.com>
gcc/rust/ChangeLog:

	* checks/lints/unused/rust-unused-checker.cc (UnusedChecker::visit):
	New.

gcc/testsuite/ChangeLog:

	* rust/compile/unreachable-patterns_0.rs: New test.

Signed-off-by: Lucas Ly Ba <lucas.ly-ba@outlook.com>
gcc/rust/ChangeLog:

	* checks/lints/unused/rust-unused-checker.cc (UnusedChecker::visit):
	New.
	* checks/lints/unused/rust-unused-checker.h (UnusedChecker::visit):
	New.
	* rust-lang.cc (grs_langhook_init_options_struct): Enable warn_type_limits.

gcc/testsuite/ChangeLog:

	* rust/compile/unused-comparisons_0.rs: New test.

Signed-off-by: Lucas Ly Ba <lucas.ly-ba@outlook.com>
gcc/rust/ChangeLog:

	* checks/lints/unused/rust-unused-checker.cc (is_numeric): New.
	(UnusedChecker::visit): New.
	* checks/lints/unused/rust-unused-checker.h (UnusedChecker::visit):
	New.

gcc/testsuite/ChangeLog:

	* rust/compile/trivial-numeric-casts_0.rs: New test.

Signed-off-by: Lucas Ly Ba <lucas.ly-ba@outlook.com>
Warn on bounds applied to the generic parameters of a type alias, as
those bounds are not enforced.

gcc/rust/ChangeLog:

	* checks/lints/unused/rust-unused-checker.cc (UnusedChecker::visit):
	New.
	* checks/lints/unused/rust-unused-checker.h (UnusedChecker::visit):
	New.

gcc/testsuite/ChangeLog:

	* rust/compile/type-alias-bounds_0.rs: New test.

Signed-off-by: Lucas Ly Ba <lucas.ly-ba@outlook.com>
Warn when two range patterns in a match overlap on a single endpoint,
for example `0..=5` and `5..=10` which both match `5`.

gcc/rust/ChangeLog:

	* checks/lints/unused/rust-unused-checker.cc
	(UnusedChecker::visit(HIR::MatchExpr)): Warn on overlapping range
	endpoints.

gcc/testsuite/ChangeLog:

	* rust/compile/overlapping-range-endpoints_0.rs: New test.

Signed-off-by: Lucas Ly Ba <lucas.ly-ba@outlook.com>
@lucasly-ba
lucasly-ba force-pushed the combined-unused-lints branch 2 times, most recently from 57628b2 to cfbde77 Compare September 6, 2026 15:16
@lucasly-ba

Copy link
Copy Markdown
Contributor Author

@philberty should be good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants