You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Grader LTI bugfix and force send all updates - #1584
First commit makes sure that instructor grade changes get sent via LTI even if "auto updates" are turned off.
Second adds a checkbox to the regrade wizard so instructors can forcibly resend even unchanged grades to LTI. Default is false.
This is useful if you do something like change grade reporting from points to percent, open an assignment in your LMS that some students had already done on the RS side, etc...
This pull request introduces a new option to the regrade workflow that allows instructors to force the resending of all assignment totals via LTI, even if the scores have not changed. This affects both the frontend and backend, ensuring that the new option is available in the UI, passed through the API, and handled correctly in the grading logic. Additional tests have been added to verify the new behavior and its interaction with existing options.
Key changes include:
Frontend (UI and API integration):
Added a "Resend all scores via LTI (force update even unchanged)" checkbox to the RegradeWizard UI, which defaults to off and is included in both preview and run requests. When enabled, it also forces "Recompute assignment totals" to be enabled and disables its checkbox. [1][2][3][4]
Extended the RegradeRequest interface to include the new resend_all_scores_via_lti boolean property, ensuring the option is sent to the backend.
Backend (API and logic):
Updated the backend API models (RegradeRequest and RegradeOptions) and endpoints to accept and forward the resend_all_scores_via_lti flag. [1][2][3][4]
Modified the core regrade logic so that when the resend option is enabled, assignment totals are recomputed and pushed to the LMS for all students, even if their scores are unchanged. The force flag is now forwarded through the relevant functions to support this behavior. [1][2][3][4][5]
Testing:
Added and updated tests to cover the new resend option, ensuring that unchanged totals are pushed to the LMS when requested, and that the force flag is handled correctly throughout the stack. [1][2][3][4]
Other:
Added documentation and code comments to clarify the new behavior and its intent.
This test calls regrade_batch with its default instructor_triggered=False, so line 746 passes force=False and the assertion below fails. The default is needed by the student route, which also calls regrade_batch; explicitly mark this test invocation as instructor-triggered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit makes sure that instructor grade changes get sent via LTI even if "auto updates" are turned off.
Second adds a checkbox to the regrade wizard so instructors can forcibly resend even unchanged grades to LTI. Default is false.
This is useful if you do something like change grade reporting from points to percent, open an assignment in your LMS that some students had already done on the RS side, etc...
This pull request introduces a new option to the regrade workflow that allows instructors to force the resending of all assignment totals via LTI, even if the scores have not changed. This affects both the frontend and backend, ensuring that the new option is available in the UI, passed through the API, and handled correctly in the grading logic. Additional tests have been added to verify the new behavior and its interaction with existing options.
Key changes include:
Frontend (UI and API integration):
RegradeWizardUI, which defaults to off and is included in both preview and run requests. When enabled, it also forces "Recompute assignment totals" to be enabled and disables its checkbox. [1] [2] [3] [4]RegradeRequestinterface to include the newresend_all_scores_via_ltiboolean property, ensuring the option is sent to the backend.Backend (API and logic):
RegradeRequestandRegradeOptions) and endpoints to accept and forward theresend_all_scores_via_ltiflag. [1] [2] [3] [4]forceflag is now forwarded through the relevant functions to support this behavior. [1] [2] [3] [4] [5]Testing:
forceflag is handled correctly throughout the stack. [1] [2] [3] [4]Other: