Skip to content

Add runtime tests for ICU code paths in formatting functions - #1799

Open
HenrikPaetzold wants to merge 6 commits into
masterfrom
henrik/formatting-tests
Open

Add runtime tests for ICU code paths in formatting functions#1799
HenrikPaetzold wants to merge 6 commits into
masterfrom
henrik/formatting-tests

Conversation

@HenrikPaetzold

@HenrikPaetzold HenrikPaetzold commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

This Pull Request adds runtime tests for the ICU interface, built from the example tables in
the F&O 3.1 specification. Expected values are derived from the spec and from CLDR.

Several things that failed, have been fixed:

  • [F] and [P] ignored their default presentation modifier n, returning an abbreviation
    resp. a hard-coded string instead of a name.
  • Name width handling was wrong in three ways: no padding to the minimum, abbreviating even
    when the full name fitted the maximum, and accepting an abbreviation below the minimum
    (German [MN,3-3] gave J instead of Jan).
  • CLDR soft hyphens (U+00AD) leaked into German and Italian numerals, breaking eq and
    string-length on results that looked correct.
  • An uninterpretable o(...) specifier fell back to cardinals in fr/it/es but to ordinals in
    de/en, purely from how CLDR names its rule sets.
  • AH used ICU's astronomical Islamic calendar; the tabular variant matches the spec example.

@github-actions

github-actions Bot commented Aug 15, 2026

Copy link
Copy Markdown

QT3 Test Results - Parser: jsoniq

Regression baseline: run 31613200034

🎉 No regressions found for this build.

Summary of passed tests for jsoniq
Test Suite Passing Failing Errors Skipped Total
app 1984 39 127 7 2157
array 207 0 1 1 209
fn 10024 381 232 498 11135
map 220 0 0 0 220
math 149 0 0 0 149
misc 700 77 34 60 871
op 4192 63 70 41 4366
prod 10344 569 465 829 12207
ser 321 21 1 0 343
xs 147 6 0 11 164
Total 28288 1156 930 1447 31821

Full analysis report: see analysis-jsoniq in artifacts.

Download detailed test results

@github-actions

github-actions Bot commented Aug 15, 2026

Copy link
Copy Markdown

QT3 Test Results - Parser: xquery

Regression baseline: run 31613200034

🎉 No regressions found for this build.

Summary of passed tests for xquery
Test Suite Passing Failing Errors Skipped Total
app 2024 38 88 7 2157
array 207 0 1 1 209
fn 10078 343 216 498 11135
map 220 0 0 0 220
math 149 0 0 0 149
misc 719 64 28 60 871
op 4284 14 27 41 4366
prod 10571 442 365 829 12207
ser 343 0 0 0 343
xs 153 0 0 11 164
Total 28748 901 725 1447 31821

Full analysis report: see analysis-xquery in artifacts.

Download detailed test results

@HenrikPaetzold
HenrikPaetzold force-pushed the henrik/formatting-tests branch from 9b079d7 to 695a4d3 Compare August 16, 2026 07:36
@HenrikPaetzold
HenrikPaetzold force-pushed the henrik/formatting-tests branch from 695a4d3 to 565d67f Compare August 16, 2026 07:44
@HenrikPaetzold
HenrikPaetzold marked this pull request as ready for review August 16, 2026 07:47
@HenrikPaetzold
HenrikPaetzold force-pushed the henrik/formatting-tests branch 2 times, most recently from ca8b779 to 978154e Compare August 16, 2026 08:12
@HenrikPaetzold
HenrikPaetzold force-pushed the henrik/formatting-tests branch from 978154e to d0e2b50 Compare August 16, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant