fix(segment): enforce maxReps exactly

[shadowhand]

Goal

Make a field declared with maxReps: N accept exactly N repetitions, as SV-83 specifies.

Changes

• Compare the 0-based repetition index against the maximum with >=, so indices 0..N-1 are allowed and the (N+1)th throws OutOfBoundsException.
• Report the 1-based repetition number in the exception message, with correct singular/plural, so it agrees with the allowed count.
• Fix the test that enshrined the off-by-one and add coverage for maxReps: 1 and PID|1~2||X.
• Add a CHANGELOG entry under Fixed.

Refs SV-83

[github-actions]

The Robin Hood of code review

✅ Review done. Nothing worth flagging — looks clean to me.

Push fixes whenever you like, then comment /robin for another pass.

_{Robin v2.12.0 · antongulin/robin@main (fc0bf91) · agent review: 6 turns · 14 tool calls}

[github-actions]

The Robin Hood of code review

Heads up: this is a point-in-time review. Push fixes freely, then comment /robin whenever you want another pass.

✅ No issues found

Summary

The change fixes the off-by-one check so capped fields accept no more than their configured repetition count, and reports repetition ordinals consistently as 1-based. The added tests cover both a general cap and parsing a repeated PID. I found no actionable issues in the diff.