Repository navigation
feat(interactions): add Show more to long call notes (FE-241) - #1851
paulfalgout wants to merge 1 commit into
Conversation
paulfalgout
added
the
ci:defer-cypress
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 40 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic analysis
No issues found across 5 files
Linked issue analysis
Linked issue: FE-241: Add Show more to long interaction notes
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | Clamp long call notes to four lines | The collapsed summary has a four-line max-height, and the E2E fixture checks that a longer note overflows. |
| ✅ | Show the control only for overflow, at line four’s bottom right | ResizeObserver measures rendered overflow before revealing the button; CSS positions it bottom-right and reserves room on line four. |
| ✅ | Expand the full note once, with no Show less | Clicking Show more sets noteExpanded, rerenders the full text, and removes the button. |
| ✅ | Retain expansion on rerender and reset on return | Expansion lives on the item view, and the E2E spec checks retention after refresh and reset after leaving the timeline. |
| ✅ | Preserve the full note text and line breaks | The template renders summary without truncation, and the E2E spec asserts exact text including embedded line breaks. |
| ✅ | Support keyboard activation | The E2E spec focuses the button, activates it with Enter, and checks focus moves to the expanded note. |
| ✅ | Show overflow at responsive widths | The E2E spec checks that resizing reveals the control at 700 pixels and hides it again at 1920 pixels. |
| Support light and dark themes | The button uses the shared blue color token, but the diff shows no explicit theme-specific styling or verification. | |
| ✅ | Keep the behavior scoped to the Interactions timeline | Collapsing is limited to call items outside activity feeds, and the E2E spec checks that activity notes remain unchanged. |
Long call notes in the Interactions timeline now show four lines with a bottom-right Show more control only when the rendered text overflows. Expanding reveals the full note once; view-local state survives item rerenders and resets when the timeline/list is replaced. Activity feeds retain their existing full notes.
FE-241
Validation:
npm run lint,npm run build,git diff --check, and focused Handlebars/YAML checks passed. Added coverage in the existing interactions E2E spec for overflow, responsive widths, keyboard focus, rerender retention, reset, and activity-feed scope. Cypress and browser layout verification are deferred; no local Cypress run or coverage claim.Summary by cubic
Adds a Show more control to overflowing call notes in the Interactions timeline, per FE-241. Notes now clamp to four lines with the control at the bottom right only when text actually overflows; expanding reveals the full note once, with no Show less. Expansion is kept in view-local state so it survives rerenders but resets when the timeline is replaced or revisited. Activity feeds and short notes are unchanged.
Written for commit 72c9ec8. Summary will update on new commits.