Skip to content

Add type check step to CI frontend tests#1207

Merged
mihow merged 1 commit intomainfrom
chore/ci-type-check
Apr 3, 2026
Merged

Add type check step to CI frontend tests#1207
mihow merged 1 commit intomainfrom
chore/ci-type-check

Conversation

@annavik
Copy link
Copy Markdown
Member

@annavik annavik commented Apr 3, 2026

In this PR we add a type check step to the CI frontend tests.

Closes #1202

Summary by CodeRabbit

  • Chores
    • Enhanced CI/CD pipeline with TypeScript type-checking validation during automated builds.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 3, 2026

Deploy Preview for antenna-ssec ready!

Name Link
🔨 Latest commit e911a9b
🔍 Latest deploy log https://app.netlify.com/projects/antenna-ssec/deploys/69cf83006f6d52000896f136
😎 Deploy Preview https://deploy-preview-1207--antenna-ssec.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 3, 2026

Deploy Preview for antenna-preview ready!

Name Link
🔨 Latest commit e911a9b
🔍 Latest deploy log https://app.netlify.com/projects/antenna-preview/deploys/69cf82ff57ef3000080dbf51
😎 Deploy Preview https://deploy-preview-1207--antenna-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 62 (🔴 down 3 from production)
Accessibility: 89 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8bf6fa63-9c78-413c-8331-4437b13d2ee3

📥 Commits

Reviewing files that changed from the base of the PR and between 6573ada and e911a9b.

📒 Files selected for processing (2)
  • .github/workflows/test.frontend.yml
  • ui/package.json

📝 Walkthrough

Walkthrough

Integrates TypeScript type checking into the frontend CI pipeline by adding a tsc --noEmit npm script to ui/package.json and incorporating it as a dedicated step in the GitHub Actions lint job workflow configuration.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/test.frontend.yml
Updated Node.js setup path quoting convention (single to double quotes). Added new yarn type-check step to the lint job that executes after yarn lint, integrating TypeScript type validation into CI.
Package Scripts
ui/package.json
Added type-check npm script executing tsc --noEmit for TypeScript type validation without emitting compiled output.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Whiskers twitch with delight at the sight,
Type errors now caught in CI's spotlight!
No more sneaky bugs through the build they creep,
tsc checks keep the codebase in leap!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and lacks required template sections like List of Changes, Detailed Description, How to Test, and Checklist. While it references the closed issue, most template elements are missing. Expand the description to include List of Changes, Detailed Description explaining the type-check implementation, How to Test section, and complete the Checklist to match the repository's template.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: adding a type check step to CI frontend tests, which aligns with the modifications to the workflow and package.json.
Linked Issues check ✅ Passed The PR implements Option C (CI-only check) from issue #1202 by adding tsc --noEmit as a dedicated step in the frontend CI workflow, fully addressing the requirement to run TypeScript type checking before CI/Netlify builds.
Out of Scope Changes check ✅ Passed All changes are directly related to implementing TypeScript type checking in CI. The quoting style change in the workflow is a minor formatting adjustment; no extraneous or unrelated modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/ci-type-check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mihow mihow merged commit a4bd212 into main Apr 3, 2026
7 of 9 checks passed
@mihow mihow deleted the chore/ci-type-check branch April 3, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add TypeScript type checking to pre-commit or CI

2 participants