fix: use provider_urls config for embedding driver base_url#413
Open
castorinop wants to merge 1 commit intoRightNow-AI:mainfrom
Open
fix: use provider_urls config for embedding driver base_url#413castorinop wants to merge 1 commit intoRightNow-AI:mainfrom
castorinop wants to merge 1 commit intoRightNow-AI:mainfrom
Conversation
- Add base_url_override parameter to create_embedding_driver() - Pass URL from config.provider_urls to embedding driver for ollama, openai - Add unit tests for URL override functionality Fixes embedding fallback when using remote Ollama provider
Member
|
thanks for this! we're reviewing and may implement this differently to fit our architecture. will keep you posted |
jaberjaber23
added a commit
that referenced
this pull request
Mar 11, 2026
Member
|
implemented in v0.3.46 — embedding driver now respects provider_urls config and auto-selects the right model per provider. thanks @castorinop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes embedding fallback when using remote Ollama provider
Summary
Changes
Testing
cargo clippy --workspace --all-targets -- -D warningspassescargo test --workspacepassesSecurity