docs(server): drop redundant public-URL rationale comment (RIG-2717) - #692
Merged
Merged
Conversation
… (RIG-2848) The RIG-2848 notification-matrix test double still returned the removed ingest.ChecksResult placeholder, which RIG-2732 (#677) collapsed into the real forge.ConditionalResult[forge.Checks] when it landed the conditional-read seam. The two PRs merged in an order that left main red — compass-go:vet/test fail-closed on `undefined: ingest.ChecksResult` in server/forge_notify_matrix_test.go, blocking every compass PR at the pre-push gate. Update matrixChecksRoller's field and RollUp return to forge.ConditionalResult[forge.Checks] (the forge import already present), matching the ChecksRoller interface. Mechanical adapter fix; the signature dictates the exact change. Spec-impact: none. Refs RIG-2848 Co-authored-by: Matt Wilkinson <matt@rigel.build>
Remove the floating comment above errUsage that editorialized the no-default public-URL decision with deployment/business framing ("the managed-service host is a deployment concern that never lives in this repo"). It attaches to no declaration and every behavioral fact it stated is already documented at its proper home: the --public-url flag help (no default, must be set), requirePublicURL / errNoPublicURL (empty rejected at boot for a Linear-webhook deploy), and deepLinkFor (empty base yields a relative fragment). The rationale prose reads as out-of-place editorializing in the OSS product's source. Follow-up to #639 (merged at its pre-fix head).
Spec-impact: none. Refs RIG-2717
Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
Compass engineering docs preview: https://compass-server-rig-2717-comm-2hcj.compass-eng-docs.pages.dev Deployed from |
Base automatically changed from
compass-server/rig-2848-checksroller-fix
to
main
August 27, 2026 23:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 2 PRs:
mainRemove the floating comment above errUsage that editorialized the no-default public-URL decision with deployment/business framing ("the managed-service host is a deployment concern that never lives in this repo"). It attaches to no declaration and every behavioral fact it stated is already documented at its proper home: the --public-url flag help (no default, must be set), requirePublicURL / errNoPublicURL (empty rejected at boot for a Linear-webhook deploy), and deepLinkFor (empty base yields a relative fragment). The rationale prose reads as out-of-place editorializing in the OSS product's source. Follow-up to #639 (merged at its pre-fix head).
Spec-impact: none. Refs RIG-2717
Co-authored-by: Matt Wilkinson matt@rigel.build