docs(infra): CI check-name convention + no-op edited-run suppression (RIG-2791) - #663
Open
rigel-mintaka wants to merge 1 commit into
Open
docs(infra): CI check-name convention + no-op edited-run suppression (RIG-2791)#663rigel-mintaka wants to merge 1 commit into
rigel-mintaka wants to merge 1 commit into
Conversation
…(RIG-2791) Design record for RIG-2791, ruling Matt's two-part ask on PR #591: - A (ruled A1): a slash-namespaced kebab check-name convention — every ci.yml gate job renames to `ci / <job>`; the required `CI` rollup stays `CI` so ruleset 20090117 is untouched; sibling single-job workflows take the bare kebab stem. Absorbs RIG-2739 (dogfood-e2e -> e2e). - B (goal ruled B1; mechanism open): suppress the no-op `pull_request.edited` phantom run jj-vine fires on every PR. A triggered run cannot post zero contexts, so `edited` must leave ci.yml's `types:` behind a dedicated guard workflow. The re-trigger mechanism is the one load-bearing Open Question (OQ1) — dispatch-mode recommended after a red-team surfaced two blockers in the label-bounce path (the GITHUB_TOKEN no-trigger rule; and Renovate labelling every dependency PR). Diagnosis grounded in #591's check-runs: affected detection is NOT broken — the real run ran the full TS battery green. The phantom is the second, self-skipped `edited` run double-listing contexts (incl. a raw `Moon battery (${{ matrix.group }})` and a `skipped` `CI`), a cosmetic artifact today with a latent skipped-required-as-passing false-green. Ledger-impact: adds DL-269 (naming convention) and DL-270 (edited-run suppression) under a new `## Infrastructure & CI` section. Ids are provisional against concurrent ledger appends; reconciled at merge. Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
force-pushed
the
compass-repo/rig-2791-ci-check-naming
branch
from
August 27, 2026 02:33
b79542f to
dff5f4b
Compare
|
Compass engineering docs preview: https://compass-repo-rig-2791-ci-che.compass-eng-docs.pages.dev Deployed from Changed pages: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design record for RIG-2791, ruling Matt's two-part ask on PR #591:
gate job renames to
ci / <job>; the requiredCIrollup staysCIsoruleset 20090117 is untouched; sibling single-job workflows take the bare
kebab stem. Absorbs RIG-2739 (dogfood-e2e -> e2e).
pull_request.editedphantom run jj-vine fires on every PR. A triggered run cannot post zero
contexts, so
editedmust leave ci.yml'stypes:behind a dedicatedguard workflow. The re-trigger mechanism is the one load-bearing Open
Question (OQ1) — dispatch-mode recommended after a red-team surfaced two
blockers in the label-bounce path (the GITHUB_TOKEN no-trigger rule; and
Renovate labelling every dependency PR).
Diagnosis grounded in #591's check-runs: affected detection is NOT broken —
the real run ran the full TS battery green. The phantom is the second,
self-skipped
editedrun double-listing contexts (incl. a rawMoon battery (${{ matrix.group }})and askippedCI), a cosmeticartifact today with a latent skipped-required-as-passing false-green.
Ledger-impact: adds DL-264 (naming convention) and DL-265 (edited-run
suppression) under a new
## Infrastructure & CIsection.Co-authored-by: Matt Wilkinson matt@rigel.build