marketing: open contact modal from self-hosted card#740
Merged
Conversation
Astro treated {company} as a JS expression and tried to evaluate an
undefined identifier, blanking the page. Wrap it as a string literal so
it renders verbatim.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 5d44ca5 | May 09 2026, 07:33 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 5d44ca5 | Commit Preview URL Branch Preview URL |
May 09 2026, 07:33 PM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/storage-core
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-google-discovery
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
The native <dialog> approach broke layout on mobile and a stray JSX comment was rendering as text. Swap to a hydrated React component built on @executor-js/react's Dialog primitive (radix-ui under the hood) with CopyButton for the template and email rows, so the modal opens reliably on mobile via the trigger button.
The Astro modal hydrated but rendered unstyled because Tailwind only scanned apps/marketing/src, so the positioning utilities baked into the react lib's Dialog (fixed/translate/z-50/etc.) never landed in the CSS bundle. Add @source for the dialog/button/copy-button files we use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mailto:link with a button that opens a modal containing a copyable outreach template (Hi Rhys, I'm at {company} and interested in self hosting executor.) and the contact email with its own copy buttoncopy-btnstyling and add small handlers for opening/closing the<dialog>and copying from a target elementTest plan
{company}Generated by Claude Code