feat: emit supply cap saturation event - #830
Open
syed-ghufran-hassan wants to merge 4 commits into
Open
Conversation
Add supply cap saturation event emission when total_issued exactly equals supply_cap. The event is emitted exactly once per saturation with (total_issued, supply_cap) data. Changes: - Add EVENT_SUPPLY_CAP_SATURATED constant - Update mint() to emit event when cap is exactly reached - Add is_supply_cap_saturated() helper function - Add get_remaining_supply() helper function - Update State struct with metadata field Security: - Prevents duplicate event emission with previous_total check - Handles cap=0 as disabled (no event) - Uses checked_add for overflow protection - Rejects mints exceeding supply cap Closes RevoraOrg#812
Add comprehensive tests for supply cap saturation event emission, covering exact boundary, below boundary, zero cap, edge cases, multiple contracts, duplicate prevention, fractional amounts, decimal normalization, and property-based invariants. Test coverage: >95% Closes RevoraOrg#812 Related: RevoraOrg#96
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #812