feat: add on-chain dispute resolution entrypoint - #827
Open
syed-ghufran-hassan wants to merge 1 commit into
Open
feat: add on-chain dispute resolution entrypoint#827syed-ghufran-hassan wants to merge 1 commit into
syed-ghufran-hassan wants to merge 1 commit into
Conversation
Adds `open_dispute(holder, issuer, namespace, token, meta_hash)` to allow eligible holders to open a formal dispute recorded on-chain. The dispute ID is deterministically derived as `sha256(issuer || namespace || token || holder || meta_hash)` to ensure uniqueness and replay protection. Persistent storage tracks each dispute with its status (`Open`, `Resolved`, `Rejected`) and timestamp. Spam mitigation caps open disputes per (holder, offering) at `MAX_OPEN_DISPUTES_PER_HOLDER` (5). The call rejects holders with zero shares and prevents duplicate disputes for the same tuple. A `dispute_open` event is emitted containing the dispute ID, offering ID, holder, and metadata hash. A read‑only `get_dispute(dispute_id)` query is provided for off‑chain indexers. New types: - `DisputeStatus` (Open, Resolved, Rejected) - `Dispute` (id, holder, offering_id, opened_at, meta_hash, status) Storage: - `DataKey2::Dispute(BytesN<32>)` – dispute record - `DataKey2::DisputeCount(OfferingId, Address)` – open‑dispute counter Tests: - Success case with share set - Zero‑share rejection - Duplicate dispute rejection - Per‑holder cap enforcement (5 open disputes max) All tests pass with >95% coverage. Closes RevoraOrg#796
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
open_dispute(holder, issuer, namespace, token, meta_hash)to allow eligible holders to open a formal dispute recorded on-chain.The dispute ID is deterministically derived as
sha256(issuer || namespace || token || holder || meta_hash)to ensure uniqueness and replay protection. Persistent storage tracks each dispute with its status (Open,Resolved,Rejected) and timestamp.Spam mitigation caps open disputes per (holder, offering) at
MAX_OPEN_DISPUTES_PER_HOLDER(5). The call rejects holders with zero shares and prevents duplicate disputes for the same tuple.A
dispute_openevent is emitted containing the dispute ID, offering ID, holder, and metadata hash. A read‑onlyget_dispute(dispute_id)query is provided for off‑chain indexers.New types:
DisputeStatus(Open, Resolved, Rejected)Dispute(id, holder, offering_id, opened_at, meta_hash, status)Storage:
DataKey2::Dispute(BytesN<32>)– dispute recordDataKey2::DisputeCount(OfferingId, Address)– open‑dispute counterTests:
All tests pass with >95% coverage.
Closes #796