feat: harden cron windows, KYC dual-key, FX quorum, payout runbook - #812
Closed
Calebstack wants to merge 1 commit into
Closed
feat: harden cron windows, KYC dual-key, FX quorum, payout runbook#812Calebstack wants to merge 1 commit into
Calebstack wants to merge 1 commit into
Conversation
Close remaining Wave acceptance gaps for deferred distribution cron schedules (RevoraOrg#661), payout reconciliation runbook/alerts (RevoraOrg#666), KYC webhook dual-key rotation (RevoraOrg#676), and FX quorum variance guard (RevoraOrg#704).
|
@Calebstack Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR closes remaining Wave acceptance gaps for four related backend hardening issues: deferred distribution cron windows, payout reconciliation runbook/alerting, KYC webhook dual-key rotation, and FX quorum variance guard.
Related Issue
Closes #661
Closes #666
Closes #676
Closes #704
Changes
🗓️ Deferred distribution cron windows (#661)
src/db/migrations/025_create_distribution_schedules.sqlcron+ timezone window definitions.src/services/cronScheduleService.tsCronWindowValidatorbefore write; rejects Stellar maintenance overlaps and logs diffs.src/services/distributionScheduler.tsscheduler.window.rejectedmetrics/logs.📘 Payout reconciliation runbook (#666)
docs/runbooks/payout-reconciliation.mdPayoutDriftClassplaybook matrix, SEV-1 in 15 minutes rotations, Grafana screenshots-of-truth PromQL.src/services/payoutDriftDetector.tsrunbook_url+ PagerDuty description with per-class counts when alarm fires.PayoutDriftClasstype exported from payout drift repository.🔐 KYC webhook dual-key rotation (#676)
src/routes/kycWebhooks.ts— mounted at/api/v1/webhooks/kycwhen secret configured.kycWebhookAuth/verifyWebhookPayloadDualKeykyc.webhook.verified_by_key.💱 FX quorum variance guard (#704)
src/services/fxQuorumBootstrap.tsFxProviderRouterin quorum mode with paging + audit.src/index.ts— opt-in viaFX_QUORUM_ENABLED=true.fx_quorum_failed_total.Verification Results
CronScheduleService+CronWindowValidatorrunbook_url+pagerduty_descriptionfx_quorum_failed_totalalert mappingTimeline