fix: report fork_choice validator_count as null when head state missing#1433
Open
zemse wants to merge 2 commits into
Open
fix: report fork_choice validator_count as null when head state missing#1433zemse wants to merge 2 commits into
zemse wants to merge 2 commits into
Conversation
zemse
force-pushed
the
fix-1429-validator-count-null
branch
from
9d46dbf to
850d565
Compare
zemse
commented
Jun 16, 2026
zemse
force-pushed
the
fix-1429-validator-count-null
branch
from
78e29dd to
10dac6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1429.
When the node does not have the head state, the
/fork_choiceAPI used to returnvalidator_count: 0. But0is also a real count, so a reader could not tell "no validators" apart from "state is missing".Now it returns
validator_count: nullwhen the head state is missing.nullmeans "unknown".This matches leanSpec PR leanEthereum/leanSpec#1104.
Two commits: