Fix default ElevenLabs voice value and asset_db race crash - #175
Open
cyprogg wants to merge 1 commit into
Open
Conversation
- asset_components.py: ElevenLabs default voices are now returned with
descriptive names (e.g. "Chris - Charming, Down-to-Earth"), so the
hardcoded value="Chris" no longer matched any choice and crashed the
Radio component on startup. Added _pickDefaultVoice() to match by
prefix and fall back to the first available voice.
- asset_db.py: get_df() calls sync_local_assets() (which writes to
local_assets) immediately before reading remote_assets._get().
TinyMongo can transiently return None right after a write, which
crashed get_df() with AttributeError. Guard both reads with `or {}`.
|
Someone is attempting to deploy a commit to the ShortX Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two startup crashes hit while running the app fresh locally (Windows, venv, no Docker):
gui/asset_components.py: the ElevenLabs voiceRadiocomponents hardcodevalue="Chris", but ElevenLabs' default voice library now returns descriptive names (e.g."Chris - Charming, Down-to-Earth"). Since"Chris"no longer matches any entry inchoices, Gradio raisesValue: 'Chris' ... is not in the list of choicesand the UI fails to build. Added_pickDefaultVoice()to match by name prefix and fall back to the first available voice.shortGPT/config/asset_db.py:get_df()callssync_local_assets()(which writes tolocal_assets) immediately before readingcls.remote_assets._get(). TinyMongo can transiently returnNoneright after a write, which crashedget_df()withAttributeError: 'NoneType' object has no attribute 'items'. Guarded both reads withor {}.Test plan
requirements.txton Windows, ranpython runShortGPT.py, reproduced both crashes on first launch.http://localhost:31415) without errors.