Closed
Conversation
There's currently a caching issue when switching between locales on the project site [1]. To fix this we can only load the project if it has the expected locale. However, this would break caching for projects that aren't localized. The code editor only uses the project cache when you've not yet logged in or saved a project. The projects you're likely to be editing in this case are the blank starter projects. Since these projects are blank with no instructions they aren't really localizable so I have decided to flag them as having a 'global' localization. Adding this to the list of locales will mean we can also set this on any imported projects we want this behaviour for. I'll amend [1] to allow using the cache when when the project is set to global. ### After deploy Deploy separate migration to update locale for the two blank projects. [1] RaspberryPiFoundation/editor-ui#1342
Test coverage89.9% line coverage reported by SimpleCov. |
Contributor
Author
|
This was something I wanted to try, but I don't think it's needed as the starter projects do have seperate locales configured in production |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Description
There's currently a caching issue when switching between locales on the project site [1]. To fix this we can only load the project if it has the expected locale.
However, this would break caching for projects that aren't localised. The code editor only uses the project cache when you've not yet logged in or saved a project. The projects you're likely to be editing in this case are the blank starter projects. Since these projects are blank with no instructions they aren't really localizable so I have decided to flag them as having a 'global' localization.
Adding this to the list of locales will mean we can also set this on any imported projects we want this behaviour for.
I'll amend [1] to allow using the cache when when the project is set to global.
[1] RaspberryPiFoundation/editor-ui#1342
Steps to perform after deploying to production
Deploy separate migration to update locale for the two blank projects.