Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CI workflow triggers to avoid running duplicate checks on feature-branch pushes while still running CI for pull requests and for changes merged to main.
Changes:
- Restrict
push-triggered CI runs to themainbranch only. - Keep CI running for all
pull_requesttargets.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test coverage90.01% line coverage reported by SimpleCov. |
abcampo-iry
approved these changes
Mar 3, 2026
abcampo-iry
left a comment
abcampo-iry
left a comment
There was a problem hiding this comment.
This is correct.
Worth to consider, do we need to verify tags.
Otherwise good to go.
Contributor
Author
I think not - we don't tend to use them on this project (but do on editor-ui for releases) |
zetter-rpf
force-pushed
the
dont-run-tests-on-branches
branch
from
8adc809 to
6b57c79
Compare
This causes the checks to run on branches and then again on PRs
zetter-rpf
force-pushed
the
dont-run-tests-on-branches
branch
from
6b57c79 to
e3df515
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Points for consideration:
What's changed?
Currently checks to run on branches and then again on PRs resulting on duplicate checks.
Don't run tests on feature branches (until they get turned into a PR), this is similar to how the Editor-ui repo is set up.