Repository navigation
fix(channels): slack caveat comment matches the gateway's new wording - #131
Merged
Merged
Conversation
- The SlackCard doc, the Socket Mode test fixture, and two stale 'three cards' comments now track the gateway's new caveat: with Socket Mode on and channel_id set, the bot ignores every other channel while direct messages still arrive. The fixture's mock and assertion both carry the verbatim gateway sentence.
sulthannauval
deleted the
fix/channels-slack-caveat-and-stale-counts
branch
September 24, 2026 05:38
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
SlackCarddoc comment and the Socket Mode caveat test fixture still describe the pre-#844 behaviour: a channel filter under Socket Mode makes the bot ignore direct messages. RantaiClaw #844 changed that. Direct messages now reach the bot while other channels are filtered out. The console relays the gateway'swarningverbatim, so the fixture's mock and assertion need to track the gateway's new sentence. Two stale "three cards" comments inchannel-setup.tsxandchannels-panel.tsxalso need a count-free reword.Change
src/components/ops/channels-panel.tsx: theSlackCarddoc comment now says the card relays the gateway's caveat and that the caveat now covers other channels ignored while direct messages still arrive. TheTelegramCarddoc drops the "with three cards on the page" line and reads as count-free.src/components/ops/channels-panel.test.tsx: thewarningmock and thedescriptionassertion both carry the verbatim gateway sentence: "Socket Mode is on and channel_id is set: the bot ignores every channel except that one. Direct messages still reach it. Clear channel_id to accept every channel." The test block comment above is reworded to match.src/components/ops/channel-setup.tsx: thechannelKeyfield doc loses "three cards" and reads "so the cards can coexist".CHANGELOG.md: one bullet under## [Unreleased]### Fixed.Non-goals
Verification
npm run lint: exit 0, 0 errors, 39 pre-existing warnings, none in the touched files.npm test: 764 tests passed across 55 files (matches fix(channels): lark allowlist label names open_id #130's prior record).npm run build: clean.npm run e2e: 11 passed againstRantAIClaw/target/release/rantaiclaw(the releasedv0.31.0-alphabinary).descriptionassertion atchannels-panel.test.tsx:746to the old sentence made the "shows the gateway's Socket Mode caveat" test go red (deeptoEqualmismatch at line 745); restored.Risk and rollback
Risk: low. Comment, fixture, and changelog text only. Nothing rendered by the card changes, so behaviour and screenshots stay identical. Rollback is a single revert of this PR.