Skip to content

fix(channels): slack caveat comment matches the gateway's new wording - #131

Merged
sulthannauval merged 1 commit into
mainfrom
fix/channels-slack-caveat-and-stale-counts
Sep 24, 2026
Merged

sulthannauval merged 1 commit into
mainfrom
fix/channels-slack-caveat-and-stale-counts

Conversation

@sulthannauval

Copy link
Copy Markdown
Member

Problem

The SlackCard doc comment and the Socket Mode caveat test fixture still describe the pre-#844 behaviour: a channel filter under Socket Mode makes the bot ignore direct messages. RantaiClaw #844 changed that. Direct messages now reach the bot while other channels are filtered out. The console relays the gateway's warning verbatim, so the fixture's mock and assertion need to track the gateway's new sentence. Two stale "three cards" comments in channel-setup.tsx and channels-panel.tsx also need a count-free reword.

Change

  • src/components/ops/channels-panel.tsx: the SlackCard doc comment now says the card relays the gateway's caveat and that the caveat now covers other channels ignored while direct messages still arrive. The TelegramCard doc drops the "with three cards on the page" line and reads as count-free.
  • src/components/ops/channels-panel.test.tsx: the warning mock and the description assertion both carry the verbatim gateway sentence: "Socket Mode is on and channel_id is set: the bot ignores every channel except that one. Direct messages still reach it. Clear channel_id to accept every channel." The test block comment above is reworded to match.
  • src/components/ops/channel-setup.tsx: the channelKey field doc loses "three cards" and reads "so the cards can coexist".
  • CHANGELOG.md: one bullet under ## [Unreleased] ### Fixed.

Non-goals

  • No change to the gateway caveat text. The gateway owns the sentence (RantaiClaw plan 426); the console only relays it.
  • No new test. Nothing rendered changes; the existing "shows the gateway's Socket Mode caveat" test pins the new sentence at both the mock and the assertion.
  • No rework of the e2e suite. E2E runs against the released gateway, which does not send this caveat anyway.

Verification

  • npm run lint: exit 0, 0 errors, 39 pre-existing warnings, none in the touched files.
  • npm test: 764 tests passed across 55 files (matches fix(channels): lark allowlist label names open_id #130's prior record).
  • npm run build: clean.
  • npm run e2e: 11 passed against RantAIClaw/target/release/rantaiclaw (the released v0.31.0-alpha binary).
  • Mutation: reverting the description assertion at channels-panel.test.tsx:746 to the old sentence made the "shows the gateway's Socket Mode caveat" test go red (deep toEqual mismatch at line 745); restored.

Risk and rollback

Risk: low. Comment, fixture, and changelog text only. Nothing rendered by the card changes, so behaviour and screenshots stay identical. Rollback is a single revert of this PR.

- The SlackCard doc, the Socket Mode test fixture, and two stale 'three cards' comments now track the gateway's new caveat: with Socket Mode on and channel_id set, the bot ignores every other channel while direct messages still arrive. The fixture's mock and assertion both carry the verbatim gateway sentence.
@sulthannauval
sulthannauval merged commit 373f85f into main Sep 24, 2026
2 checks passed
@sulthannauval
sulthannauval deleted the fix/channels-slack-caveat-and-stale-counts branch September 24, 2026 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant