[CI] Increase rocDecode and rocJPEG Code Coverage - #183
Merged
bgopesh merged 9 commits intoSep 3, 2025
Merged
Conversation
abchoudh-amd
pushed a commit
that referenced
this pull request
Aug 8, 2025
* swdev-510794 Adding MPI usage with rocprofv3 * update doc * Fixed build issues * updating doc * doc update * Fixed Typos * csv format * change format to shell [ROCm/rocprofiler-sdk commit: 7821657]
jayhawk-commits
pushed a commit
that referenced
this pull request
Aug 8, 2025
* [SWDEV-531379] Fix config Signed-off-by: adapryor <Adam.pryor@amd.com> Change-Id: Ie1bd6903235016a185dd93fbac0a87658fb12a62 * Fix group field find Signed-off-by: adapryor <Adam.pryor@amd.com> Change-Id: I1f8c62615327df4b5ca916b158b4882a3d5a59d0 * fixes Signed-off-by: adapryor <Adam.pryor@amd.com> Change-Id: I971f3e12e293ea9e5d4d67db64d8d7217b87561c --------- Signed-off-by: adapryor <Adam.pryor@amd.com> [ROCm/rdc commit: 8663702]
xuchen-amd
pushed a commit
that referenced
this pull request
Aug 10, 2025
* SWDEV-460151 - add gfx1201 to amd-staging clr * SWDEV-460151 - removed pal macro --------- Co-authored-by: Jimbo Xie <jiabaxie@amd.com>
xuchen-amd
pushed a commit
that referenced
this pull request
Aug 10, 2025
* SWDEV-528351 - Adds hipTexRefSetGet* tests * SWDEV-528351 - Adds hipTexRefSetGet* tests * SWDEV-528351 - Adds hipTexRefSetGet* tests
itrowbri
force-pushed
the
import/develop/ROCm_rocprofiler-sdk/itrowbri_rocdecode-rocjpeg-test-coverage
branch
from
August 11, 2025 20:40
5133cae to
cbb613f
Compare
Collaborator
|
venkat1361
self-requested a review
August 12, 2025 15:54
venkat1361
approved these changes
Aug 12, 2025
jrmadsen
force-pushed
the
import/develop/ROCm_rocprofiler-sdk/itrowbri_rocdecode-rocjpeg-test-coverage
branch
from
August 18, 2025 15:55
cbb613f to
c2fd6b3
Compare
github-actions
Bot
added
the
github actions
itrowbri
force-pushed
the
import/develop/ROCm_rocprofiler-sdk/itrowbri_rocdecode-rocjpeg-test-coverage
branch
from
August 18, 2025 17:59
c2fd6b3 to
386ef6e
Compare
jayhawk-commits
pushed a commit
that referenced
this pull request
Aug 18, 2025
* SWDEV-460151 - add gfx1201 to amd-staging clr * SWDEV-460151 - removed pal macro --------- Co-authored-by: Jimbo Xie <jiabaxie@amd.com> [ROCm/clr commit: a5d932f]
jayhawk-commits
pushed a commit
that referenced
this pull request
Aug 18, 2025
* SWDEV-528351 - Adds hipTexRefSetGet* tests * SWDEV-528351 - Adds hipTexRefSetGet* tests * SWDEV-528351 - Adds hipTexRefSetGet* tests [ROCm/hip-tests commit: d6f415c]
itrowbri
force-pushed
the
import/develop/ROCm_rocprofiler-sdk/itrowbri_rocdecode-rocjpeg-test-coverage
branch
from
August 19, 2025 15:37
386ef6e to
10d026f
Compare
itrowbri
force-pushed
the
import/develop/ROCm_rocprofiler-sdk/itrowbri_rocdecode-rocjpeg-test-coverage
branch
from
August 19, 2025 16:23
10d026f to
5cd9dbc
Compare
systems-assistant Bot
pushed a commit
that referenced
this pull request
Aug 19, 2025
* SWDEV-528351 - Adds hipTexRefSetGet* tests * SWDEV-528351 - Adds hipTexRefSetGet* tests * SWDEV-528351 - Adds hipTexRefSetGet* tests
itrowbri
force-pushed
the
import/develop/ROCm_rocprofiler-sdk/itrowbri_rocdecode-rocjpeg-test-coverage
branch
2 times, most recently
from
August 21, 2025 15:12
985e39b to
62c1729
Compare
jrmadsen
approved these changes
Aug 21, 2025
itrowbri
force-pushed
the
import/develop/ROCm_rocprofiler-sdk/itrowbri_rocdecode-rocjpeg-test-coverage
branch
from
August 26, 2025 14:22
62c1729 to
0458183
Compare
bwelton
force-pushed
the
import/develop/ROCm_rocprofiler-sdk/itrowbri_rocdecode-rocjpeg-test-coverage
branch
from
September 2, 2025 15:46
0458183 to
8a20435
Compare
itrowbri
force-pushed
the
import/develop/ROCm_rocprofiler-sdk/itrowbri_rocdecode-rocjpeg-test-coverage
branch
from
September 2, 2025 20:03
8a20435 to
d534dff
Compare
bgopesh
force-pushed
the
import/develop/ROCm_rocprofiler-sdk/itrowbri_rocdecode-rocjpeg-test-coverage
branch
from
September 3, 2025 11:12
d534dff to
9fc1262
Compare
Contributor
|
As soon as |
bgopesh
force-pushed
the
import/develop/ROCm_rocprofiler-sdk/itrowbri_rocdecode-rocjpeg-test-coverage
branch
from
September 3, 2025 13:49
9fc1262 to
fd6484e
Compare
Contributor
|
|
bgopesh
deleted the
import/develop/ROCm_rocprofiler-sdk/itrowbri_rocdecode-rocjpeg-test-coverage
branch
September 3, 2025 13:50
systems-assistant Bot
pushed a commit
to ROCm/rocprofiler-sdk
that referenced
this pull request
Sep 3, 2025
* Increase rocDecode code coverage and add version check * Update rocJPEG tests * Fix rocJPEG tests * Enable building tests/samples in rocm release compat workflow * Readded rocJPEG test skips * formatting * Adding ROCm libraries for the code-coverage job * Added return value check for error message and updated compatability to enable tests * Disable rocm_release_compatibility samples and tests until openmp issue is resolved [rocm-systems] ROCm/rocm-systems#183 (commit 2cfedef)
ammallya
pushed a commit
that referenced
this pull request
Jan 21, 2026
* API support for enabling rocshmem bitcode integration * move implementation to along with host side APIs
ammallya
pushed a commit
that referenced
this pull request
Jan 21, 2026
ammallya
pushed a commit
that referenced
this pull request
Jan 21, 2026
* API support for enabling rocshmem bitcode integration * move implementation to along with host side APIs [ROCm/rocshmem commit: 1053827]
ammallya
pushed a commit
that referenced
this pull request
Jan 21, 2026
dayatsin-amd
pushed a commit
that referenced
this pull request
Apr 7, 2026
…s-develop-636 Merger auto-merge-rocm-systems-develop-636 into amd-npi-compute-external-merge-new-636
ammallya
pushed a commit
that referenced
this pull request
Apr 9, 2026
ammallya
pushed a commit
that referenced
this pull request
Apr 9, 2026
If hipFile is used as a subproject in another project, `CMAKE_SOURCE_DIR` will point to the root of *that* project instead of ours, which could break the build. These changes use alternative paths to address this. Part of AIHIPFILE-129 [ROCm/hipFile commit: 370110a]
dgaliffiAMD
added a commit
that referenced
this pull request
Jun 27, 2026
…7618) ## Motivation <!-- Explain the purpose of this PR and the goals it aims to achieve. --> This is the improved other half of #6116 `ROCPROFSYS_TRACE_LEGACY` encodes information that is missing from debug args when trace cache is used. For example, with `pthread_create`, we currently see: <img width="764" height="105" alt="image" src="https://github.com/user-attachments/assets/5b21f817-565f-4628-b546-787d3c51c3a2" /> But with `ROCPROFSYS_TRACE_LEGACY=ON`, we see: <img width="766" height="198" alt="image" src="https://github.com/user-attachments/assets/b591831e-c867-475c-ac44-908ae9588495" /> There is a clear disconnect. ## Technical Details <!-- Explain the changes along with any relevant GitHub links. --> `category_region.hpp` Cache gotcha/perfetto region arguments into the trace cache. Category-independent helpers now live in a policy-templated helper `rocprofsys::utility::category_region<Policy>`, composed by `category_region<CategoryT>` via using `region_cache = utility::category_region<>`. The cache lifecycle's system seams (clock, trace-cache sink, thread metadata) are injected as value members through a Policy bundle - `serialize_name_value_pairs`: serializes the gotcha {"name", value} pairs into the wire format (idx;;type;;name;;value;;). - `serialize_annotation_args / serialize_return_arg`: serialize gotcha audit arguments (synthesized arg{N}-{type} names) and return values. - `has_trace_cache_arg_pairs_v`: detects the gotcha pair convention (even count, string-like name slots). - `next_arg_index`: derives the next index from the last record instead of storing a count. - `renumber_serialized_args`: renumbers an appended batch in a single string pass. - The above are static helpers; the stateful cache lifecycle (`cache_start` / `cache_stop` / `append_cache_args` / `flush_pending_cached_entries`) are instance methods reached through a per-thread `instance()`. - `append_cache_args`: appends a batch to the open entry (adopts the first batch as-is, else renumbers). - `start / start_with_args` now funnel through one start_impl. - Hooked gotcha audit incoming/outgoing paths to cache argument and return values. `regions.cpp`: - Adjust `flush` call signature. Added unit tests Added pytests - two new binaries: `annotations.cpp` and `pthread.cpp`. The first tests perfetto annotations and the second verifies that gotcha arguments are captured. - Both ROCpd and perfetto outputs are verified. **OTHER** `test_shmem_gotcha.cpp`: Drop `name` and `[this]`. It was causing workflow to fail: https://github.com/ROCm/rocm-systems/actions/runs/27972186388/job/82780906185 ## JIRA ID <!-- If applicable, mention the JIRA ID resolved by this PR (Example: Resolves SWDEV-12345). --> <!-- Do not post any JIRA links here. --> Jira ID : AIPROFSYST-519 ## Test Plan New unit tests New pytests: ``` minimal-pthreads-binary-rewrite minimal-pthreads-runtime-instrument minimal-pthreads-sys-run ``` <!-- Explain any relevant testing done to verify this PR. --> ## Test Result Unit tests pass: ``` Note: Google Test filter = category_region* [==========] Running 29 tests from 3 test suites. ... [----------] Global test environment tear-down [==========] 38 tests from 4 test suites ran. (0 ms total) [ PASSED ] 38 tests. ``` New pytests pass: ``` Start 182: minimal-pthreads-binary-rewrite 2/5 Test #182: minimal-pthreads-binary-rewrite ....... Passed 5.19 sec Start 183: minimal-pthreads-runtime-instrument 3/5 Test #183: minimal-pthreads-runtime-instrument ... Passed 6.69 sec Start 184: minimal-pthreads-sys-run 4/5 Test #184: minimal-pthreads-sys-run .............. Passed 2.14 sec ``` For `pthreads`: <img width="817" height="209" alt="image" src="https://github.com/user-attachments/assets/fa1330b8-aab7-4141-bb85-96d789da1f6e" /> <!-- Briefly summarize test outcomes. --> ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Co-authored-by: David Galiffi <David.Galiffi@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
Associated Jira Ticket Number/Link
What type of PR is this? (check all applicable)
Technical details
Added/updated tests?
Updated CHANGELOG?
Added/Updated documentation?
🔁 Imported from ROCm/rocprofiler-sdk#127
🧑💻 Originally authored by @rocm-devops