Add ROCm PQC TrustFlow KEM and signature example#469
Open
firedoil wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds a ROCm/HIP post-quantum cryptography application example under
Applications/pqc_trustflow_rocm.The example targets two innovation-development goals:
Development of currently unsupported functions:
Performance bottleneck localization and optimization:
Technical Details
This PR adds a new application example:
Applications/pqc_trustflow_rocmThe example is organized into two parts:
01_unsupported_feature_rocm_pqc_api/02_performance_bottleneck_rocm_optimization/Generated binaries, caches, secret files, temporary outputs, and large logs are intentionally excluded.
Test Plan
The example provides smoke-test and profiling entry points:
KEM correctness smoke test:
cd Applications/pqc_trustflow_rocm/01_unsupported_feature_rocm_pqc_api/kem_api bash build_hip.sh kyber768 bash run_kem_smoke_amd.shTest Result
Recorded evidence shows:
KEM correctness smoke tests pass.
Signature policy smoke tests pass.
Kyber-768 profiling identifies the sample/XOF/rejection-sampling stage as the dominant bottleneck.
Kyber-768 encaps throughput improves from about 6.00M ops/s to about 7.10M ops/s after launch-bound tuning.
Signature feature-matrix results show local wins from cp_fuse, wave64_ctrl, tail16, and adaptive candidates, while the stable default keeps the resource-aware decomp pipeline to avoid regressions.
Added/Updated documentation?
Included Visual Studio files?
Submission Checklist