Conversation
- DeviceContext.load(): add other, cache_modifier, volatile params - DeviceContext.store(): add cache_modifier param - DeviceContext.get(): add other, load_cache_modifier, store_cache_modifier params - DeviceContext.put(): add other, load_cache_modifier, store_cache_modifier params - DeviceContext.copy(): add other, load_cache_modifier, store_cache_modifier params - IrisDeviceCtx.load(): add cache_modifier, volatile params - IrisDeviceCtx.store(): add cache_modifier param - IrisDeviceCtx.get(): add load_cache_modifier, store_cache_modifier params - IrisDeviceCtx.put(): add load_cache_modifier, store_cache_modifier params - IrisDeviceCtx.copy(): add load_cache_modifier, store_cache_modifier params - Add tests: test_device_context_cache_modifiers.py - Add tests: test_gluon_cache_modifiers.py Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com> Agent-Logs-Url: https://github.com/ROCm/iris/sessions/8ce4f35c-fe72-4506-89d2-e79687a16a09
…t_gluon_cache_modifiers.py Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com> Agent-Logs-Url: https://github.com/ROCm/iris/sessions/ee387d87-c4e9-4207-b9d8-de35aba33605
|
@copilot The docstrings for cache_modifier params in both DeviceContext and Gluon are too short. Expand them to match the format used in the freestanding API (see For example, you wrote: But the freestanding API has the full expanded format: And for store: Apply this expanded format to all |
…to match freestanding API format Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com> Agent-Logs-Url: https://github.com/ROCm/iris/sessions/639da603-607c-4d81-b5af-88a77a38db97
Done in b46c8a7. Expanded all |
|
@copilot The Gluon API uses |
…with DeviceContext and freestanding API Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com> Agent-Logs-Url: https://github.com/ROCm/iris/sessions/5e77e456-b46f-4bef-b94a-8b8bfff9a473
Done in f5cfba2. Changed all Gluon |
There was a problem hiding this comment.
Pull request overview
Adds missing cache_modifier, volatile, and other parameters to DeviceContext and Gluon IrisDeviceCtx methods so they match the freestanding Iris API introduced in #158, and adds unit tests to validate the new passthrough behavior.
Changes:
- Extend
DeviceContext(load/store/get/put/copy) to accept and forward cache-modifier and masking-related parameters totl.load/tl.store. - Extend Gluon
IrisDeviceCtxmethods to accept and forwardcache_modifier/volatilewhere supported bygl.load/gl.store. - Add dedicated unit tests covering cache modifiers across all 5 methods for both APIs.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 27 comments.
| File | Description |
|---|---|
| iris/iris.py | Extends DeviceContext method signatures and forwards args to Triton loads/stores. |
| iris/experimental/iris_gluon.py | Extends Gluon IrisDeviceCtx method signatures and forwards args to gl.load/gl.store. |
| tests/unittests/test_device_context_cache_modifiers.py | Adds coverage for DeviceContext cache modifiers / volatile across all 5 methods. |
| tests/unittests/test_gluon_cache_modifiers.py | Adds equivalent coverage for Gluon IrisDeviceCtx cache modifiers / volatile across all 5 methods. |
|
@copilot The CI failures in Root cause: The kernel Reproduction output: Fix: Make the remote store test consistent. The simplest fix is to make Look at how Important: You have access to AMD GPUs on this runner. Please run the full test suite with |
… kernel instead of hardcoding partner Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com> Agent-Logs-Url: https://github.com/ROCm/iris/sessions/3e67c439-de61-437e-97f4-318c4f05d925
Fixed in 59f07b8. Added |
DeviceContextandIrisDeviceCtx(Gluon) were missingcache_modifier,volatile, andotherparameters that existed on the freestanding API (iris.load,iris.store, etc.) since #158.DeviceContext (
iris/iris.py)Added missing parameters to all 5 methods, passed through to
tl.load()/tl.store():loadother,cache_modifier,volatilestorecache_modifiergetother,load_cache_modifier,store_cache_modifierputother,load_cache_modifier,store_cache_modifiercopyother,load_cache_modifier,store_cache_modifierGluon (
iris/experimental/iris_gluon.py)gl.load()andgl.store()supportcache_modifierandvolatile, so all 5IrisDeviceCtxmethods are updated with the same parameters. Defaults useNone(consistent with the freestanding API andDeviceContext).Usage
Tests
tests/unittests/test_device_context_cache_modifiers.py: mirrors the existing freestanding cache modifier tests for all 5DeviceContextmethodstests/unittests/test_gluon_cache_modifiers.py: equivalent coverage forIrisDeviceCtxOriginal prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.