Added fix to version check issue#5
Open
Micky774 wants to merge 1 commit into
Open
Conversation
ipanfilo
reviewed
Jun 24, 2026
| # checker must go straight to the real compiler — don't route through | ||
| # _handle_link_step which may fail when there's no -o argument. | ||
| if len(argv) == 2 and argv[1] in ("-v", "-V", "--version", "--help"): | ||
| # In CXX role (not hipcc), CK_JIT_CXX may be hipcc captured from the |
Collaborator
There was a problem hiding this comment.
The code here is identical to run_real_compiler except using CK_JIT_CXX env, so it is better add optional argument to run_real_compiler(argv, version_check=False) that will skip env for version_check.
The problem is also not in fake rocm PATH but it is a bug in ROCm clang++: /opt/rocm/llvm/bin/clang++ -v fails w/o CK_JIT as well. It is seen with ROCm 7.2.3 but seems fixed in ROCm 7.13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes an issue with version checking as part of the
ROCM_PATHreplacement.Technical Details
Test Plan
Test Result
Submission Checklist