[Kernel][MI350] Add bias, alibi bias and sink to flash attention - #960
[Kernel][MI350] Add bias, alibi bias and sink to flash attention#960amd-nprotaso wants to merge 20 commits into
Conversation
…d-nprotaso/FlyDSL into new_bias_alibi_sink_attention
ebeaa5e to
fe6db3f
Compare
jhinpan
left a comment
There was a problem hiding this comment.
I found one correctness blocker in the new sink integration, plus two smaller actionable issues in bias validation/pipelining. I reproduced the sink/LSE failure on gfx950 (Sq=512, Skv=128); the device CI for this head did not run because prepare-mlir timed out. I also tested odd-pitch and storage-offset bias tensors on gfx950 and did not report alignment as a finding because identical inputs produced identical kernel outputs.
yanguahe
left a comment
There was a problem hiding this comment.
Additional review findings. The first two are specific to this PR. The ragged dense-paged issue appears to be pre-existing, but it remains relevant because the new paged-bias API and test currently avoid rather than reject the unsupported case.
|
updated performance: D=128 H=32 H_KV=8 dtype=torch.bfloat16
Bias:
Alibi:
|
Add bias, alibi bias and sink to flash attention 950gfx implementation.
performance: D=128 H=32 H_KV=8 dtype=torch.bfloat16
Without bias and alibi
Bias:
Alibi: