Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/.nav.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ nav:
- Hardware Profiling Guide: getting_started/hardware-profiling.md
- Operators:
- operators/README.md
- operators/activation.md
- operators/fused-logp.md
- operators/linear-logp.md
- operators/grpo-loss.md
Expand Down
1 change: 1 addition & 0 deletions docs/operators/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Every operator page should include:

## Current Pages

- [SiLU / SwiGLU Activation](activation.md)
- [Fused LogP](fused-logp.md)
- [Fused Linear LogP](linear-logp.md)
- [GRPO Loss](grpo-loss.md)
Expand Down
112 changes: 112 additions & 0 deletions docs/operators/activation.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,112 @@
# SiLU / SwiGLU Activation

The activation operators are the element-wise core of the Qwen3/Llama gated MLP. They are
**WS1 ground-truth references** (issue #108): pure-PyTorch, fp32-accumulating definitions of
the "correct answer" that downstream fused CUDA/Triton MLP kernels are validated against.

- **SiLU** (`NativeSiLUOp`): `silu(x) = x * sigmoid(x)` — the `hidden_act="silu"` gate.
- **SwiGLU** (`NativeSwiGLUOp`): `swiglu(gate, up) = silu(gate) * up` — the gated MLP middle
stage. `gate` / `up` are the `gate_proj` / `up_proj` outputs (already at the intermediate
width); the following `down_proj` is a plain Matmul and is **not** part of this operator.

```text
hidden --gate_proj--> gate --\
swiglu --> down_proj --> hidden
hidden --up_proj----> up ----/
```

## Entry Point
```python
from rl_engine.kernels.registry import kernel_registry

silu = kernel_registry.get_op("silu")
swiglu = kernel_registry.get_op("swiglu")

# SiLU: single element-wise activation
y = silu(x) # [..., N] -> [..., N]

# SwiGLU: gated activation (gate and up must share shape)
h = swiglu(gate, up) # [..., I], [..., I] -> [..., I]
```

Both ops expose the WS1 dual-path contract:

- `forward(...)` — computes in fp32, casts back to the input dtype (Axis-B accuracy
candidate / dtype-behavior path).
- `forward_fp32(...)` — computes and returns fp32 (the ground-truth golden path).

## Backends

| Backend | Wrapper | Native symbol | Status |
| --- | --- | --- | --- |
| PyTorch fallback | `NativeSiLUOp` / `NativeSwiGLUOp` | None | fp32 ground-truth reference; CPU and any GPU. |
| CUDA / ROCm / Triton | — | — | Planned: downstream fused MLP kernels validate against this reference. |

## Tensor Contract

| Argument | Shape | Dtype | Requirements |
| --- | --- | --- | --- |
| `x` (SiLU) | `[..., N]` | float (fp16/bf16/fp32) | Any shape; last dim arbitrary (Qwen3-8B `I=12288`). |
| `gate` (SwiGLU) | `[..., I]` | float | `gate_proj` output. |
| `up` (SwiGLU) | `[..., I]` | float | `up_proj` output; **must share `gate`'s shape**. |
| output | same as input | `forward`: input dtype · `forward_fp32`: float32 | Same shape as input. |

Element-wise and shape-agnostic: the Qwen3-8B intermediate dim `I=12288` is just one valid
last-dim size, not a hard requirement. Pure functions — no randomness, no in-place
mutation, device/dtype follow the inputs.

## Dispatch Behavior

`kernel_registry.get_op("silu" | "swiglu")` resolves through the `OpBackend` priority map.
On `cuda` / `rocm` / `cpu` the only registered backend today is the PyTorch native op
(`PYTORCH_NATIVE_SILU` / `PYTORCH_NATIVE_SWIGLU`), so every device dispatches to the
fp32 reference. When fused kernels land, they are prepended to the priority list and the
native op becomes the fallback.

## Accuracy

Reference semantics (`forward_fp32`, fp32 accumulation):

```python
# SiLU
out = x.float() * torch.sigmoid(x.float())

# SwiGLU
gate_f = gate.float()
out = gate_f * torch.sigmoid(gate_f) * up.float()
```

- **Ground truth**: `forward_fp32` always accumulates in and returns fp32.
- **Dtype path**: `forward` runs the same fp32 math, then casts back to the input dtype;
it is bitwise-equal to `forward_fp32(x).to(dtype)`.
- **Axis A — batch invariance**: element-wise and row-independent, so a row's output is
bitwise-identical regardless of batch size or padding (`torch.equal`, `atol=0`).
- **Axis B — tolerance**: as `elementwise` ops, low-precision tolerance follows the
`elementwise` row of the WS1 numerical contract.

## Performance Notes

Reference operators — no fused kernel or benchmark yet. Downstream fused MLP kernels carry
their own benchmarks and are measured against this reference for correctness.

## Tests

```bash
python -m pytest tests/test_swiglu.py -v
```

Covers: correctness vs an independent fp32 formula, dtype paths, Axis-A batch invariance
(slice + padding), input purity, gradient flow, the SwiGLU shape guard, and registry
dispatch.

## Implementation Files

- `rl_engine/kernels/ops/pytorch/activation/swiglu.py`
- `rl_engine/kernels/registry.py`
- `tests/test_swiglu.py`

## Known Limitations

- PyTorch fallback only; no fused CUDA/Triton backend yet (downstream work).
- SwiGLU requires `gate` and `up` to share shape (raises `ValueError` otherwise); no
broadcasting.
2 changes: 2 additions & 0 deletions rl_engine/kernels/ops/pytorch/activation/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# SPDX-License-Identifier: Apache-2.0
# Copyright (c) 2026 RL-Kernel Contributors
86 changes: 86 additions & 0 deletions rl_engine/kernels/ops/pytorch/activation/swiglu.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
# SPDX-License-Identifier: Apache-2.0
# Copyright (c) 2026 RL-Kernel Contributors

from __future__ import annotations

import torch
import torch.nn as nn


class NativeSiLUOp(nn.Module):
"""
Pure PyTorch native SiLU reference.
out = x * sigmoid(x) (a.k.a. Swish)

Element-wise activation used by the Qwen3 SwiGLU MLP
(hidden_act="silu"). No hyper-parameters and shape-agnostic, so the
Qwen3-8B intermediate dim (12288) is just one valid last-dim size.
"""

def __init__(self) -> None:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just like the RMSNorm op, these pure PyTorch reference operators should inherit from nn.Module to ensure seamless integration with the broader PyTorch ecosystem (Hooks, state_dict, Dynamo tracing) later down the line.
Bonus: Because nn.Module automatically handles routing call to forward, you can safely delete the manually defined call methods in both classes, making the code even cleaner.

super().__init__()

def forward(self, x: torch.Tensor) -> torch.Tensor:
"""
Canonical entry: compute in fp32, cast the result back to x.dtype.
This is the dtype-behavior path used as the Axis-B accuracy candidate.
"""
return self._silu(x, output_dtype=x.dtype)

def forward_fp32(self, x: torch.Tensor) -> torch.Tensor:
"""Ground-truth: compute in fp32 and force fp32 output."""
return self._silu(x, output_dtype=torch.float32)

# ------------------------------------------------------------------ #
# Helpers
# ------------------------------------------------------------------ #
@staticmethod
def _silu(x: torch.Tensor, *, output_dtype: torch.dtype) -> torch.Tensor:
x_f = x.float()
out = x_f * torch.sigmoid(x_f)
return out.to(output_dtype)


class NativeSwiGLUOp(nn.Module):
"""
Pure PyTorch native SwiGLU reference.
out = silu(gate) * up = (gate * sigmoid(gate)) * up

Middle stage of the Qwen3/Llama MLP: ``gate`` and ``up`` are the
gate_proj / up_proj outputs (already at intermediate dim 12288). The
following down_proj is a plain Matmul and lives in a separate op.
Element-wise and shape-agnostic; ``gate`` and ``up`` must share shape.
"""

def __init__(self) -> None:
super().__init__()

def forward(self, gate: torch.Tensor, up: torch.Tensor) -> torch.Tensor:
"""
Canonical entry: compute in fp32, cast the result back to gate.dtype.
This is the dtype-behavior path used as the Axis-B accuracy candidate.
"""
return self._swiglu(gate, up, output_dtype=gate.dtype)

def forward_fp32(self, gate: torch.Tensor, up: torch.Tensor) -> torch.Tensor:
"""Ground-truth: compute in fp32 and force fp32 output."""
return self._swiglu(gate, up, output_dtype=torch.float32)

# ------------------------------------------------------------------ #
# Helpers
# ------------------------------------------------------------------ #
@staticmethod
def _swiglu(
gate: torch.Tensor,
up: torch.Tensor,
*,
output_dtype: torch.dtype,
) -> torch.Tensor:
if gate.shape != up.shape:
raise ValueError(
f"gate and up must share shape, got tuple(gate.shape)="
f"{tuple(gate.shape)} vs tuple(up.shape)={tuple(up.shape)}"
)
gate_f = gate.float()
out = gate_f * torch.sigmoid(gate_f) * up.float()
return out.to(output_dtype)
8 changes: 8 additions & 0 deletions rl_engine/kernels/registry.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ class OpBackend(Enum, metaclass=_KernelEnumMeta):
TRITON_GENERIC = "rl_engine.kernels.ops.triton.generic.TritonOp"
PYTORCH_ATTN = "rl_engine.kernels.ops.pytorch.attention.NativeAttentionOp"
PYTORCH_NATIVE = "rl_engine.kernels.ops.pytorch.loss.logp.NativeLogpOp"
PYTORCH_NATIVE_SILU = "rl_engine.kernels.ops.pytorch.activation.swiglu.NativeSiLUOp"
PYTORCH_NATIVE_SWIGLU = "rl_engine.kernels.ops.pytorch.activation.swiglu.NativeSwiGLUOp"


class KernelRegistry:
Expand Down Expand Up @@ -89,6 +91,8 @@ def __init__(self):
"grpo_loss": [OpBackend.TRITON_GRPO_LOSS, OpBackend.PYTORCH_GRPO_LOSS],
"linear_logp": [OpBackend.TRITON_LINEAR_LOGP, OpBackend.PYTORCH_LINEAR_LOGP],
"ratio_kl": [OpBackend.TRITON_RATIO_KL, OpBackend.PYTORCH_RATIO_KL],
"silu": [OpBackend.PYTORCH_NATIVE_SILU],
"swiglu": [OpBackend.PYTORCH_NATIVE_SWIGLU],
# Default dispatch logic for new operators
},
"rocm": {
Expand All @@ -101,13 +105,17 @@ def __init__(self):
"grpo_loss": [OpBackend.TRITON_GRPO_LOSS, OpBackend.PYTORCH_GRPO_LOSS],
"linear_logp": [OpBackend.TRITON_LINEAR_LOGP, OpBackend.PYTORCH_LINEAR_LOGP],
"ratio_kl": [OpBackend.TRITON_RATIO_KL, OpBackend.PYTORCH_RATIO_KL],
"silu": [OpBackend.PYTORCH_NATIVE_SILU],
"swiglu": [OpBackend.PYTORCH_NATIVE_SWIGLU],
},
"cpu": {
"logp": [OpBackend.PYTORCH_NATIVE],
"attn": [OpBackend.PYTORCH_ATTN],
"grpo_loss": [OpBackend.PYTORCH_GRPO_LOSS],
"linear_logp": [OpBackend.PYTORCH_LINEAR_LOGP],
"ratio_kl": [OpBackend.PYTORCH_RATIO_KL],
"silu": [OpBackend.PYTORCH_NATIVE_SILU],
"swiglu": [OpBackend.PYTORCH_NATIVE_SWIGLU],
},
}
logger.info(f"KernelRegistry initialized for {device_ctx.device_type}")
Expand Down
Loading
Loading