Pass ... to parent constructor#717
Open
hadley wants to merge 5 commits into
Open
Conversation
There are two cases where it's not safe to re-use the deafults from the parent in a subclass constructor: * When the parent comes from another package, because the specification might change between class construction and object instantaition. Fixes #317. * When the parent constructor is custom, because we don't know anything about its environment. Fixes #609. This does not make external parent classes entirely safe because it's possible the parent can make backward incompatible changes leading to run-time errors. But I think we believe that's outside of the scope of S7, and something that you'd discover when running your revdep checks prior to CRAN submission.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two cases where it's not safe to re-use the deafults from the parent in a subclass constructor:
This does not make external parent classes entirely safe because it's possible the parent can make backward incompatible changes leading to run-time errors. But I think we believe that's outside of the scope of S7, and something that you'd discover when running your revdep checks prior to CRAN submission.