#239 docs: pass bare substrings to like filters in every example - #245
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #239
The generated
likebinding escapes%,_and\\in the value and wraps the result in%...%. Every documented example passed a value that already carried wildcards, so the documented call escaped them into literals and matched nothing.likesection states that the macro adds the wildcards and escapes the ones the caller supplies.likeis always a substring match — prefix- or suffix-only matching is not expressible through it.sort_keysettrybuild case stopped modelling the wrong call.search— which binds the term as given, so a%there is a wildcard — is now stated in the README and in all five wiki pages.The behaviour itself is already covered by the live-Postgres suite:
query_filters_and_sortsasserts that a value containing%matches literally.