Repository navigation
Y051: Flag redundant negative integer literals - #561
Merged
Merged
Conversation
|
This change has no effect on typeshed. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
Literal[-1], the-1is parsed as a unary minus applied to a constant rather than as anast.Constant, so the Y051 check skipped it.int | Literal[-1]andUnion[Literal[-5], int]were not reported at all, and forint | Literal[-1, 5]the error pointed atLiteral[5]instead of the first redundant member.This makes the Y051 check treat a negated integer constant as an
intliteral. I added these cases totests/union_duplicates.pyi, together withstr | Literal[-1], which is still not flagged, and a changelog entry.The new test cases fail without the change, and the full test suite passes with it on Python 3.11 on Windows; flake8, mypy (
--python-version3.10 and 3.15), black and isort are clean.