Repository navigation
B017, B022: check every item of a multi-item with statement - #646
Open
shivangithaker-0510 wants to merge 1 commit into
Open
shivangithaker-0510 wants to merge 1 commit into
shivangithaker-0510 wants to merge 1 commit into
Conversation
Both checks only looked at node.items[0], so `with open(path), pytest.raises(Exception):` and `with open(path), contextlib.suppress():` were not reported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
B017 and B022 only look at the first item of a
withstatement (node.items[0]), so they miss the offending context manager whenever it isn't listed first:B908 already loops over all
node.items; this does the same for B017 and B022. Most of the diff is just re-indentation (git diff -wis 4 lines).Before: neither line above is reported. After: B017 / B022 are reported on them, same as when the context manager is the only item. Added cases to
tests/eval_files/b017.pyandb022.py(including awith open(...) as f, pytest.raises(Exception) as ex:that should stay clean) and a changelog line under UNRELEASED.Used Claude to help write this; I reviewed it and ran the tests.