Repository navigation
Conversation
…-for # Conflicts: # README.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
visit_Forcallscheck_for_b007andcheck_for_b020, butvisit_AsyncForonly calls the B045 and B023 checks, so an unused loop variable or a loop that rebinds its own iterable isn't reported when the loop isasync for:On main this file gives no errors. The same loops without
asyncgive B007 on line 2 and B020 on line 4. Now the async loops get both too. I left B031, B909 and B913 out: they are aboutgroupby(), mutating a list, dict or set, andzip(), andasync forraises a TypeError on each of those. That includes theasync for k in d.keys()case mentioned in the review of #596. Added async cases totests/eval_files/b007.pyandb020.pyand a changelog line.