Remove unused code for zarr v3 specific handling from test_zarr_avg_merger#8724
Remove unused code for zarr v3 specific handling from test_zarr_avg_merger#8724Borda wants to merge 2 commits intoProject-MONAI:devfrom
test_zarr_avg_merger#8724Conversation
…t_zarr_avg_merger` Signed-off-by: jirka <[email protected]>
📝 WalkthroughWalkthroughThis change modifies zarr compressor handling in test code. The conversion from compressor to codecs now only applies for zarr v2, while v3 uses codecs directly. The refactoring removes 32 lines of code that previously contained zarr v3-specific codec mappings, eliminating the separate v3 conversion branch for compressor, value_compressor, and count_compressor arguments. Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This pull request removes unused code that was intended to handle zarr v3 specific conversion of compressor arguments to codecs. The removed code was dead because test cases already handle version detection at test case definition time, providing either compressor arguments for zarr v2 or codecs arguments for zarr v3.
Changes:
- Removed conditional logic that converted
compressor,value_compressor, andcount_compressorarguments to codec lists when zarr v3 is active - Simplified the code to only process compressor arguments for zarr v2
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
testt_zarr_avg_mergertest_zarr_avg_merger
This pull request simplifies the handling of compressor and codec arguments in the
test_zarr_avg_merger_patchestest by removing the logic specific to zarr v3. Now, compressor-related arguments are only processed for zarr v2, which streamlines the code and reduces complexity.Compressor and codec handling simplification:
compressor,value_compressor, andcount_compressorarguments when using zarr v3; these arguments are now only processed for zarr v2, eliminating the conversion to codec lists for v3 and related code paths.Description
according to the coverage report it is unused code: https://app.codecov.io/gh/Project-MONAI/MONAI/blob/dev/tests%2Finferers%2Ftest_zarr_avg_merger.py
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.