Accept dev versions of coq, coq-compcert and coq-flocq in coq-vst.opam#860
Closed
JasonGross wants to merge 3 commits into
Closed
Accept dev versions of coq, coq-compcert and coq-flocq in coq-vst.opam#860JasonGross wants to merge 3 commits into
JasonGross wants to merge 3 commits into
Conversation
Allows installing on a switch tracking Rocq master (e.g. pinned rocq-core dev builds); release constraints are unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019ttctspSoVoquHLQtbPVZw
The main coqdep invocation piped through grep with `|| true`, so a
coqdep that dies partway (e.g. killed under memory pressure) silently
leaves a truncated .depend; the `.depend depend:` rule has no
prerequisites, so later builds reuse the poisoned file and parallel
make compiles files before their dependencies exist ("Unable to locate
library ..." errors). Write to a temporary file, fail the build if
coqdep fails, keep the warning filtering, and move the file in place
only on success.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019ttctspSoVoquHLQtbPVZw
coqdep in current Rocq dev leaks one file descriptor per located warning (fix proposed as rocq-prover/rocq#22278); over this tree's thousands of module-not-found warnings it dies with "Too many open files" under the common 1024 soft limit. Raise the soft limit to the hard limit for the coqdep invocation as a harmless workaround for affected Rocq versions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019ttctspSoVoquHLQtbPVZw
Collaborator
|
@JasonGross can you explain further? How is this branch going to track the master branch? Will you have to fastforward from time to time? And why need a P.R. instead of just a fork branch? |
Contributor
Author
|
Moving discussion to #861 which is not capturing other commits. (I accidentally opened the PR from my branch combining a handful of fixes, rather than separating them out.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows installing a pin to this branch on a switch tracking Rocq master