refactor: remove "auto" option from fused_lm_head_token_chunk_size#2890
Merged
Conversation
The "auto" value for fused_lm_head_token_chunk_size previously resolved to 8192 for RL training via a config validator. This was redundant since users can simply set the integer explicitly. Remove the "auto" option, its validator (auto_setup_fused_lm_head_token_chunk_size), and update docs/CHANGELOG accordingly. The type changes from int | Literal["auto", "disabled"] to int | Literal["disabled"]. Users who relied on "auto" should set fused_lm_head_token_chunk_size = 8192 explicitly.
mikasenghaas
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
"auto"option frommodel.fused_lm_head_token_chunk_size. This value previously resolved to8192for RL training via theauto_setup_fused_lm_head_token_chunk_sizeconfig validator. It was redundant — users can simply set the integer explicitly.Changes
packages/prime-rl-configs/src/prime_rl/configs/trainer.py:int | Literal["auto", "disabled"]→int | Literal["disabled"]auto_setup_fused_lm_head_token_chunk_sizevalidator (was a no-op for non-"auto"values)"auto"mentiondocs/scaling.md: Removed the commented# fused_lm_head_token_chunk_size = "auto"example lineCHANGELOG.md: Added breaking-change entryMigration
Users who relied on
"auto"should setfused_lm_head_token_chunk_size = 8192explicitly:Notes
1024(unchanged)"disabled"(vanilla LM head) and explicit integers continue to work as before"disabled")"auto"for this fieldNote
Low Risk
Small, localized trainer config validation and documentation change with a clear migration path; no runtime training logic beyond dropping the auto-resolve step.
Overview
Breaking config change:
model.fused_lm_head_token_chunk_sizeno longer accepts"auto". The field is nowint | Literal["disabled"]only; the default stays 1024.The
auto_setup_fused_lm_head_token_chunk_sizevalidator that rewrote"auto"→8192for RL is removed. Anyone who relied on"auto"should setfused_lm_head_token_chunk_size = 8192explicitly."disabled"and explicit integers behave as before; SFT still forces this off.Docs (
scaling.md) drop the commented"auto"example; CHANGELOG documents the migration.Reviewed by Cursor Bugbot for commit b83e6ab. Bugbot is set up for automated code reviews on this repo. Configure here.