feat: add a torch to the starting home#493
Merged
Merged
Conversation
The new-world starting home now includes a Torch on a free interior corner (left+1, bottom-1), distinct from the bed/chest top corners, so the starting shelter has a light source. Torch is already registered in roomJsonReaderWriter, so it persists across save/reload. Closes #492 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
Self-review rubric (reviewed by Claude; CI green on head):
Note: the box's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StartingHomeGenerator.generatenow places aTorchon the bottom-left interior corner(left+1, bottom-1). The bed and chest occupy the two top corners, so the torch corner is free / collision-free.Torchis already registered inroomJsonReaderWriter.py, so the home (torch included) persists across save/reload.Test plan
python3 -m compileall src -qcleanSDL_VIDEODRIVER=dummy SDL_AUDIODRIVER=dummy python3 -m pytest→ 930 passed (was 929; +1)test_torch_is_placed_on_a_free_interior_cornerasserts the torch at(6,10)in a 17×17 room and no collision with bed/chestblackclean on changed filesCloses #492
🤖 Generated with Claude Code