Documentation: Improve Power Flow Method Comparisions#1306
Documentation: Improve Power Flow Method Comparisions#1306nitbharambe merged 14 commits intomainfrom
Conversation
Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
Jerry-Jinfeng-Guo
added
the
documentation
There was a problem hiding this comment.
Pull request overview
Updates the user manual’s power flow documentation to help users choose an appropriate calculation method (per #1003) by adding a more practical comparison and selection guidance.
Changes:
- Replaces the power flow algorithm comparison table with columns focused on convergence and typical use cases.
- Adds a “Choosing the right power flow algorithm” section with selection guidance based on accuracy, speed, and grid characteristics.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
figueroa1395
left a comment
figueroa1395
left a comment
There was a problem hiding this comment.
Looks good to me. Nothing more to add besides what was already pointed out.
Co-authored-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com> Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Co-authored-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com> Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Co-authored-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com> Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
figueroa1395
left a comment
figueroa1395
left a comment
There was a problem hiding this comment.
Minor comments only. Looks good to me.
|
@nitbharambe should #1316 follow after this one? Do you think it isn't needed? Or what's the status there? |
Co-authored-by: Santiago Figueroa Manrique <figueroa1395@gmail.com> Co-authored-by: Martijn Govers <martygovers@hotmail.com> Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers
left a comment
mgovers
left a comment
There was a problem hiding this comment.
OK with the current state but i have 2 minor comments. feel free to resolve them if you disagree
figueroa1395
left a comment
figueroa1395
left a comment
There was a problem hiding this comment.
LGTM. No more comments from my side.
Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
|
Improvements as requested in #1003