S3 Stream Writer: simpler and more robust logic#136
Open
ahouene wants to merge 8 commits intoPowerDNS:mainfrom
Open
S3 Stream Writer: simpler and more robust logic#136ahouene wants to merge 8 commits intoPowerDNS:mainfrom
ahouene wants to merge 8 commits intoPowerDNS:mainfrom
Conversation
Luit
reviewed
Apr 2, 2026
backends/s3/stream.go
Outdated
| _ = pr.CloseWithError(err) | ||
| cancel() | ||
| }(ctx, b, name, pr, cancel) | ||
| return &writerWrapper{b, nil, ctx, pw}, nil |
Contributor
There was a problem hiding this comment.
Field assignment in this way is error prone and less readable. I prefer to see the backend: b form.
Contributor
Author
There was a problem hiding this comment.
Fair point, I changed it!
| err = w.prevErr | ||
| _ = w.pw.CloseWithError(err) | ||
| if w.prevErr == nil { | ||
| w.prevErr = simpleblob.ErrClosed |
Contributor
There was a problem hiding this comment.
I think if you Close and then Write, the error returned from a second Close won't be ErrClosed here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the
io.WriteCloserreturned by(*s3.Backend).NewWriterto make it more robust and simple. It takes some changes out of #133, that will be rebased to result in a simpler and more obvious diff.