Skip to content

ci: test with pg 18 - #29

Merged
steve-chavez merged 3 commits into
PostgREST:masterfrom
taimoorzaeem:test-pg18
Oct 31, 2026
Merged

steve-chavez merged 3 commits into
PostgREST:masterfrom
taimoorzaeem:test-pg18

Conversation

@taimoorzaeem

Copy link
Copy Markdown
Member

Test with PG 18 in CI.

Signed-off-by: Taimoor Zaeem <taimoorzaeem@gmail.com>
Comment thread src/build.c
#include "observation.h"

const char DOT = '.';
#define DOT '.'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: wouldn't static const char.. work here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that would work too. I saw that DOT was defined in all caps, which is usually only for macros and preprocessor stuff. A const variable usually isn't all caps, so I went with this.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I think either way is fine. This should change anyway once we integrate cparsec.

Without it, `-Wmissing-variable-declaration` warning is raised when
building with `pg-18`.

Signed-off-by: Taimoor Zaeem <taimoorzaeem@gmail.com>
Signed-off-by: Taimoor Zaeem <taimoorzaeem@gmail.com>
@steve-chavez
steve-chavez merged commit 8725c6c into PostgREST:master Oct 31, 2026
7 checks passed
@taimoorzaeem
taimoorzaeem deleted the test-pg18 branch November 3, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants