Repository navigation
ci: test with pg 18 - #29
Merged
Merged
Conversation
Signed-off-by: Taimoor Zaeem <taimoorzaeem@gmail.com>
| #include "observation.h" | ||
|
|
||
| const char DOT = '.'; | ||
| #define DOT '.' |
Member
There was a problem hiding this comment.
Q: wouldn't static const char.. work here?
Member
Author
There was a problem hiding this comment.
Yes, that would work too. I saw that DOT was defined in all caps, which is usually only for macros and preprocessor stuff. A const variable usually isn't all caps, so I went with this.
Member
There was a problem hiding this comment.
Right, I think either way is fine. This should change anyway once we integrate cparsec.
Without it, `-Wmissing-variable-declaration` warning is raised when building with `pg-18`. Signed-off-by: Taimoor Zaeem <taimoorzaeem@gmail.com>
Signed-off-by: Taimoor Zaeem <taimoorzaeem@gmail.com>
taimoorzaeem
force-pushed
the
test-pg18
branch
from
October 31, 2026 05:49
2505727 to
296165c
Compare
steve-chavez
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test with PG 18 in CI.