fix: mysql volumes and ch empty secret - #224
Merged
Merged
Conversation
b4s36t4
approved these changes
Aug 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Portkey Helm chart templates to prevent cross-component volume mount configuration in the MySQL StatefulSet and to make ClickHouse Secret rendering safer when credentials are empty.
Changes:
- Removed unintended ClickHouse
volumeMountsinjection from the MySQL StatefulSet template. - Quoted the ClickHouse password secret value output to avoid empty/invalid YAML output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/portkey-app/templates/mysql/stateful-set.yaml | Removes ClickHouse-derived volume mounts from the MySQL container’s volumeMounts. |
| charts/portkey-app/templates/clickhouse/secrets.yaml | Adjusts ClickHouse Secret rendering for password output (and needs follow-up to quote other potentially-empty fields). |
Suppressed comments (1)
charts/portkey-app/templates/clickhouse/secrets.yaml:28
- Same issue in the in-cluster ClickHouse branch: unquoted empty strings (notably
clickhouse_user) render as YAML null and can fail Kubernetes schema validation for Secret.data. Quote the base64-encoded values to ensure they stay strings even when empty.
clickhouse_user: {{ .Values.clickhouse.external.user | b64enc }}
clickhouse_password: {{ .Values.clickhouse.external.password | b64enc | quote }}
clickhouse_host: {{ printf "%s-%s" (include "portkey.fullname" .) .Values.clickhouse.name | b64enc }}
clickhouse_port: {{ toString .Values.clickhouse.containerHttpPort | b64enc }}
clickhouse_native_port: {{ toString .Values.clickhouse.containerNativePort | b64enc }}
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.