Skip to content

fix: mysql volumes and ch empty secret - #224

Merged
sk-portkey merged 1 commit into
mainfrom
fix/ch_mysql
Aug 13, 2026
Merged

fix: mysql volumes and ch empty secret#224
sk-portkey merged 1 commit into
mainfrom
fix/ch_mysql

Conversation

@sk-portkey

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the Portkey Helm chart templates to prevent cross-component volume mount configuration in the MySQL StatefulSet and to make ClickHouse Secret rendering safer when credentials are empty.

Changes:

  • Removed unintended ClickHouse volumeMounts injection from the MySQL StatefulSet template.
  • Quoted the ClickHouse password secret value output to avoid empty/invalid YAML output.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
charts/portkey-app/templates/mysql/stateful-set.yaml Removes ClickHouse-derived volume mounts from the MySQL container’s volumeMounts.
charts/portkey-app/templates/clickhouse/secrets.yaml Adjusts ClickHouse Secret rendering for password output (and needs follow-up to quote other potentially-empty fields).
Suppressed comments (1)

charts/portkey-app/templates/clickhouse/secrets.yaml:28

  • Same issue in the in-cluster ClickHouse branch: unquoted empty strings (notably clickhouse_user) render as YAML null and can fail Kubernetes schema validation for Secret.data. Quote the base64-encoded values to ensure they stay strings even when empty.
  clickhouse_user: {{ .Values.clickhouse.external.user | b64enc }}
  clickhouse_password: {{ .Values.clickhouse.external.password | b64enc | quote }}
  clickhouse_host: {{ printf "%s-%s" (include "portkey.fullname" .) .Values.clickhouse.name | b64enc }}
  clickhouse_port: {{ toString .Values.clickhouse.containerHttpPort | b64enc }}
  clickhouse_native_port: {{ toString .Values.clickhouse.containerNativePort | b64enc }}

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread charts/portkey-app/templates/clickhouse/secrets.yaml
@sk-portkey
sk-portkey merged commit 576a626 into main Aug 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants