Skip to content

fix: postgres cluster dump command#72

Merged
RambokDev merged 1 commit into
mainfrom
fix/postgres-cluster
Jun 29, 2026
Merged

fix: postgres cluster dump command#72
RambokDev merged 1 commit into
mainfrom
fix/postgres-cluster

Conversation

@RambokDev

@RambokDev RambokDev commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes

    • Cluster backups now include safer drop statements for existing objects when restoring, helping avoid conflicts during recovery.
  • Chores

    • Updated a service configuration value in the deployment setup.

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 39fea5a2-71bb-459c-94ae-35d1a71abf90

📥 Commits

Reviewing files that changed from the base of the PR and between c5eaa50 and 4be54a6.

📒 Files selected for processing (2)
  • docker-compose.yml
  • src/domain/postgres/cluster/backup.rs

📝 Walkthrough

Walkthrough

Two small changes: pg_dumpall in the cluster backup now includes --clean and --if-exists flags, and the EDGE_KEY environment variable in docker-compose.yml is rotated to a new encoded value.

Changes

Backup flags and credential rotation

Layer / File(s) Summary
pg_dumpall drop-if-exists flags
src/domain/postgres/cluster/backup.rs
Adds --clean and --if-exists to the pg_dumpall invocation so generated backup SQL drops existing objects only when they exist.
EDGE_KEY rotation
docker-compose.yml
Replaces the EDGE_KEY value for the rust-app service with a new encoded token.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • Portabase/agent#55: Also rotates the rust-app EDGE_KEY value in docker-compose.yml.
  • Portabase/agent#62: Updates docker-compose.yml EDGE_KEY and modifies Rust pg_dump/pg_restore command handling in related modules.

Poem

🐇 A hop and a clean, an if-exists decree,
The dumpall now tidies what used to just be.
The EDGE_KEY rotated, fresh token in place,
Two tiny tweaks landed with bunny-like grace.
sniff sniff All clear! 🌿

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/postgres-cluster

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@RambokDev RambokDev merged commit e621671 into main Jun 29, 2026
1 of 2 checks passed
@RambokDev RambokDev deleted the fix/postgres-cluster branch June 29, 2026 13:19
@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant