Skip to content

Switch to using byte offsets as LSNs#2541

Open
fabubaker wants to merge 27 commits intodb_v4from
db_v4_/lsn-byte-offsets
Open

Switch to using byte offsets as LSNs#2541
fabubaker wants to merge 27 commits intodb_v4from
db_v4_/lsn-byte-offsets

Conversation

@fabubaker
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change? If yes is this documented?

How was this patch tested?

Are there any further changes required?

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 124389f Previous: 9823ef7 Ratio
lotr_graph/num_edges 5 ns/iter (± 0) 0 ns/iter (± 0) +∞
lotr_graph/num_nodes 135 ns/iter (± 24) 1 ns/iter (± 0) 135
lotr_graph/graph_latest 3 ns/iter (± 0) 0 ns/iter (± 0) +∞
lotr_graph_window_100/num_edges 29 ns/iter (± 0) 8 ns/iter (± 0) 3.63
lotr_graph_window_100/num_nodes 143 ns/iter (± 24) 5 ns/iter (± 0) 28.60
lotr_graph_window_10/has_node_existing 132 ns/iter (± 7) 62 ns/iter (± 11) 2.13
lotr_graph_window_10/iterate nodes 32983 ns/iter (± 77) 11339 ns/iter (± 40) 2.91
lotr_graph_window_10/iterate edges 106967 ns/iter (± 353) 48684 ns/iter (± 211) 2.20
lotr_graph_subgraph_10pc/has_edge_existing 232 ns/iter (± 9) 93 ns/iter (± 1) 2.49
lotr_graph_subgraph_10pc/num_nodes 129 ns/iter (± 39) 4 ns/iter (± 0) 32.25
lotr_graph_subgraph_10pc/has_node_existing 108 ns/iter (± 2) 34 ns/iter (± 0) 3.18
lotr_graph_subgraph_10pc/iterate nodes 2556 ns/iter (± 136) 839 ns/iter (± 5) 3.05
lotr_graph_subgraph_10pc_windowed/has_node_existing 128 ns/iter (± 8) 62 ns/iter (± 14) 2.06
lotr_graph_subgraph_10pc_windowed/iterate nodes 4422 ns/iter (± 93) 1365 ns/iter (± 3) 3.24
lotr_graph_window_50_layered/num_nodes 64611 ns/iter (± 4560) 21435 ns/iter (± 536) 3.01
lotr_graph_window_50_layered/has_node_existing 941 ns/iter (± 83) 129 ns/iter (± 12) 7.29
lotr_graph_window_50_layered/max_id 72516 ns/iter (± 2156) 25556 ns/iter (± 252) 2.84
lotr_graph_window_50_layered/iterate nodes 145785 ns/iter (± 453) 19308 ns/iter (± 47) 7.55
lotr_graph_window_50_layered/iterate edges 210387 ns/iter (± 447) 83616 ns/iter (± 1318) 2.52
lotr_graph_window_50_layered/graph_latest 109174 ns/iter (± 2378) 36649 ns/iter (± 916) 2.98
lotr_graph_persistent_window_50_layered/num_edges_temporal 593619 ns/iter (± 5558) 192686 ns/iter (± 1569) 3.08
lotr_graph_persistent_window_50_layered/num_nodes 83955 ns/iter (± 4650) 31517 ns/iter (± 779) 2.66
lotr_graph_persistent_window_50_layered/has_node_existing 1116 ns/iter (± 179) 174 ns/iter (± 83) 6.41
lotr_graph_persistent_window_50_layered/max_id 93826 ns/iter (± 731) 38024 ns/iter (± 490) 2.47
lotr_graph_persistent_window_50_layered/iterate nodes 194168 ns/iter (± 1025) 35886 ns/iter (± 191) 5.41
lotr_graph_persistent_window_50_layered/iterate edges 179679 ns/iter (± 389) 84161 ns/iter (± 596) 2.13
lotr_graph_persistent_window_50_layered/graph_latest 166016 ns/iter (± 19384) 57549 ns/iter (± 4809) 2.88
lotr_graph_persistent_window_50_layered_materialise/materialize 11632293 ns/iter (± 63965) 5298035 ns/iter (± 147912) 2.20
lotr_graph/proto_encode 5919006 ns/iter (± 54552) 1157897 ns/iter (± 73709) 5.11

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant