This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Add support for import assertion resolution#45
Open
Westbrook wants to merge 2 commits intoPolymer:masterfrom
Open
Add support for import assertion resolution#45Westbrook wants to merge 2 commits intoPolymer:masterfrom
Westbrook wants to merge 2 commits intoPolymer:masterfrom
Conversation
Author
|
Also, I ended up doing a bunch of updating before actually updating the API consumption which might not have been needed if I started with the code changes. Let me know if it's worth trying to reduce the amount of changes taken on in this PR. |
6159b6e to
c75814e
Compare
Author
|
Oh, hey, any chance of getting this added to the library? |
Author
|
When this lands/releases, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow code like:
to be processed down to
There is zero support or
with { ... }as yet, so it seemed like processing to something with at least a little support was the right call for right now.Possibly worth do a test withassertfor the currently available support, so let me know if you'd like that added as well.Looking to leverage this in
tachometerto measure the perf benefits of switching fromcomponent.css.jsfile tocomponent.cssfiles in packages for https://opensource.adobe.com/spectrum-web-components/