feat(data): support multi-status filtering on combo positions - #272
Open
kartojal wants to merge 1 commit into
Open
feat(data): support multi-status filtering on combo positions#272kartojal wants to merge 1 commit into
kartojal wants to merge 1 commit into
Conversation
kartojal
marked this pull request as ready for review
August 14, 2026 10:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEV-442/DEV-429: Supports multi-status combo position filters in Python.
Tests: lint/format, typecheck, build, unit PASS; public live PASS.
Note
Low Risk
Backward-compatible API extension (single status unchanged) with input validation and test coverage; no auth or trading-path changes.
Overview
list_combo_positionsnow acceptsstatusas a singleComboPositionStatusor a non-empty sequence of statuses (lists/tuples). Multiple values are sent to the data API as a comma-separated query param and treated as OR filters in caller order.Validation lives in
_normalize_combo_status_filter: each entry must be a valid enum, empty sequences are rejected, and a single comma-joined string (e.g."RESOLVED_WIN,RESOLVED_LOSS") is not accepted—callers must pass a sequence. Sync/async public and secure clients share the widened type and updated docstrings.Unit tests cover request shaping and edge cases; integration tests exercise single- and multi-status filters against live data.
Reviewed by Cursor Bugbot for commit 8a6112f. Bugbot is set up for automated code reviews on this repo. Configure here.