Skip to content

Add Minnesota renter's credit#7956

Open
PavelMakarchuk wants to merge 4 commits intomainfrom
fix/mn-renters-credit
Open

Add Minnesota renter's credit#7956
PavelMakarchuk wants to merge 4 commits intomainfrom
fix/mn-renters-credit

Conversation

@PavelMakarchuk
Copy link
Copy Markdown
Collaborator

@PavelMakarchuk PavelMakarchuk commented Apr 8, 2026

Summary

  • add Minnesota renter's credit variables and parameters
  • wire the credit into Minnesota refundable credits and the state property tax credit umbrella
  • add regression and integration coverage for ordinary renter-credit cases

Testing

  • python policyengine_us/tests/test_batched.py policyengine_us/tests/policy/baseline/gov/states/mn/tax/income/credits/mn_rent_constituting_property_taxes.yaml --batches 1
  • python policyengine_us/tests/test_batched.py policyengine_us/tests/policy/baseline/gov/states/mn/tax/income/credits/mn_renters_credit_household_income.yaml --batches 1
  • python policyengine_us/tests/test_batched.py policyengine_us/tests/policy/baseline/gov/states/mn/tax/income/credits/mn_renters_credit.yaml --batches 1
  • python policyengine_us/tests/test_batched.py policyengine_us/tests/policy/baseline/gov/states/mn/tax/income/mn_integration.yaml --batches 1
  • python policyengine_us/tests/test_batched.py policyengine_us/tests/policy/baseline/gov/states/mn/tax/income --batches 1
  • python -m pytest policyengine_us/tests/policy/baseline/gov/tax/income/test_legacy_state_umbrellas.py -q

Fixes #7938

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e8a542a) to head (e9579bd).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main     #7956    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            1        10     +9     
  Lines           17       141   +124     
==========================================
+ Hits            17       141   +124     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PavelMakarchuk PavelMakarchuk marked this pull request as ready for review April 9, 2026 00:36
Copy link
Copy Markdown
Collaborator

@DTrim99 DTrim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one issue to address:

[P2] Prorate assisted rent with AGI, not household income

In policyengine_us/variables/gov/states/mn/tax/income/credits/mn_renters_credit.py around lines 32-37, the assistance-paid-rent fraction is using mn_renters_credit_household_income, which is after age/disability/dependent/SEIU subtractions. Minn. Stat. 290.0693 Subd. 6(b) defines this fraction with adjusted gross income in both numerator and denominator, so older/disabled/dependent claimants in assisted facilities get under-credited here. Please base the proration ratio on the pre-subtraction household AGI/line-5 amount and add a test where assistance rent combines with an age or dependent subtraction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MN Renter's Credit (§290.0693) not implemented

2 participants